Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.7: URL rejected: Port number was not a decimal number between 0 and 65535 #1711

Closed
ssbarnea opened this issue Dec 4, 2024 · 2 comments · Fixed by #1724
Closed

v5.0.7: URL rejected: Port number was not a decimal number between 0 and 65535 #1711

ssbarnea opened this issue Dec 4, 2024 · 2 comments · Fixed by #1724
Assignees
Labels
bug Something isn't working high High Priority Issues (to be fixed within 2 sprints)

Comments

@ssbarnea
Copy link

ssbarnea commented Dec 4, 2024

Apparently codecov-action code is still... bit shaky, giving:

URL rejected: Port number was not a decimal number between 0 and 65535

See https://github.com/ansible/ansible-lint/actions/runs/12161810343/job/33917941601?pr=4412#step:8:79

The happened with usage below on a PR coming from a fork:

      - name: Upload coverage data
        uses: codecov/[email protected]
        with:
          name: ${{ matrix.name }}
          # verbose: true # optional (default = false)
          fail_ci_if_error: true
          use_oidc: true # cspell:ignore oidc

Under no circumstance this should happen.

I do suspect that adding the magic below might address the failure, I still think that current behaviour is far from desirable UX.

use_oidc: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork) }}
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Dec 4, 2024
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Dec 4, 2024
Related: codecov/codecov-action#1711

Also removes our own check because codecov API proves to not be
so reliable.
@ssbarnea
Copy link
Author

ssbarnea commented Dec 4, 2024

Apparently there is some hope with #1687

@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Dec 5, 2024
@thomasrockhu-codecov thomasrockhu-codecov added the high High Priority Issues (to be fixed within 2 sprints) label Dec 5, 2024
ssbarnea added a commit to ssbarnea/ansible-lint that referenced this issue Dec 5, 2024
Related: codecov/codecov-action#1711

Also removes our own check because codecov API proves to not be
so reliable.
@thomasrockhu-codecov thomasrockhu-codecov added the bug Something isn't working label Dec 6, 2024
@thomasrockhu-codecov
Copy link
Contributor

Taking a look at this.
@ssbarnea let me know if the new version worked for you, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high High Priority Issues (to be fixed within 2 sprints)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants