-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): update pypi packaging #604
Conversation
5dc03cc
to
1bf1eb9
Compare
❌ 5 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
056aa60
to
c21c77b
Compare
@thomasrockhu-codecov short of the broken regex, the rest should be ready even without implementing improvement suggestions in other comments — they can be declared out of the scope and filed as separate issues, I suppose. |
Thanks! I've emailed you. |
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized that the environment isn't set. Here's a patch to fix this. Additionally, add required reviewers to the environment called pypi
in the repo settings.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
@thomasrockhu-codecov additionally to that incorrect URL that I suggested initially, could you confirm you've enabled required reviewers in the environment called |
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just kidding, I think I got it |
@thomasrockhu-codecov oh, #620 broke it. Trusted Publishing doesn't yet support auth from reusable workflows due to different security considerations that aren't yet worked out fully. It's a limitation of how PyPI implements trust currently. It sometimes works almost by accident but we treat that as unsupported. This is being designed slowly, but no ETA so far. To combine it with testing, I usually have a top-level workflow with the conditional publishing jobs and that workflow calls a few reusable ones, while keeping P.S. When testing out publishing automation updates, I tend to use pre-release versions (a0/b0/rc0 etc). They are not picked up by installers by default so there's not as much harmful impact in terms of confusing the end users. |
build_assets
andbuild_for_pypi
into separate workflows that runon
pyproject.toml
because its what should be used oversetup.py
build_for_pypi
workflowfixes #466