-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Tax information to Plan Page #2997
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2997 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 902 902
Lines 13318 13322 +4
Branches 3487 3561 +74
=======================================
+ Hits 13096 13100 +4
Misses 218 218
Partials 4 4
... and 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2997 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 902 902
Lines 13318 13322 +4
Branches 3558 3490 -68
=======================================
+ Hits 13096 13100 +4
Misses 218 218
Partials 4 4
... and 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
===========================================
Coverage 98.33000 98.33000
===========================================
Files 902 902
Lines 13318 13322 +4
Branches 3487 3561 +74
===========================================
+ Hits 13096 13100 +4
Misses 218 218
Partials 4 4
... and 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2997 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 902 902
Lines 13318 13322 +4
Branches 3553 3556 +3
=======================================
+ Hits 13096 13100 +4
Misses 218 218
Partials 4 4
... and 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 831 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 831 bytes ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR aims to add the Tax ID section to the billing details page if the Tax IDs exist (an array comes back from GQL always, but could have 0 length).
We also have some minor updates to the zod schema for account details to accommodate this change, and a small change for "See all invoices" button -> "View"
Closes codecov/engineering-team#1973
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.