Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Tax information to Plan Page #2997

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

ajay-sentry
Copy link
Contributor

Description

This PR aims to add the Tax ID section to the billing details page if the Tax IDs exist (an array comes back from GQL always, but could have 0 length).

We also have some minor updates to the zod schema for account details to accommodate this change, and a small change for "See all invoices" button -> "View"

Closes codecov/engineering-team#1973

Screenshots

Screenshot 2024-07-09 at 3 46 53 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (9125b95) to head (dcc1b50).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2997   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         902      902           
  Lines       13318    13322    +4     
  Branches     3487     3561   +74     
=======================================
+ Hits        13096    13100    +4     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
...s/CurrentOrgPlan/BillingDetails/BillingDetails.tsx 100.00% <100.00%> (ø)
...entOrgPlan/LatestInvoiceCard/LatestInvoiceCard.tsx 100.00% <ø> (ø)
src/services/account/useAccountDetails.ts 95.45% <ø> (ø)

... and 4 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9125b95...dcc1b50. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (9125b95) to head (dcc1b50).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2997   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         902      902           
  Lines       13318    13322    +4     
  Branches     3558     3490   -68     
=======================================
+ Hits        13096    13100    +4     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
...s/CurrentOrgPlan/BillingDetails/BillingDetails.tsx 100.00% <100.00%> (ø)
...entOrgPlan/LatestInvoiceCard/LatestInvoiceCard.tsx 100.00% <ø> (ø)
src/services/account/useAccountDetails.ts 95.45% <ø> (ø)

... and 4 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9125b95...dcc1b50. Read the comment docs.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.33%. Comparing base (9125b95) to head (dcc1b50).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #2997   +/-   ##
===========================================
  Coverage   98.33000   98.33000           
===========================================
  Files           902        902           
  Lines         13318      13322    +4     
  Branches       3487       3561   +74     
===========================================
+ Hits          13096      13100    +4     
  Misses          218        218           
  Partials          4          4           
Files Coverage Δ
...s/CurrentOrgPlan/BillingDetails/BillingDetails.tsx 100.00% <100.00%> (ø)
...entOrgPlan/LatestInvoiceCard/LatestInvoiceCard.tsx 100.00% <ø> (ø)
src/services/account/useAccountDetails.ts 95.45% <ø> (ø)

... and 4 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9125b95...dcc1b50. Read the comment docs.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2997   +/-   ##
=======================================
  Coverage   98.33%   98.33%           
=======================================
  Files         902      902           
  Lines       13318    13322    +4     
  Branches     3553     3556    +3     
=======================================
+ Hits        13096    13100    +4     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
...s/CurrentOrgPlan/BillingDetails/BillingDetails.tsx 100.00% <100.00%> (ø)
...entOrgPlan/LatestInvoiceCard/LatestInvoiceCard.tsx 100.00% <ø> (ø)
src/services/account/useAccountDetails.ts 95.45% <ø> (ø)

... and 4 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.47% <ø> (ø)
Pages 99.15% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.18% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9125b95...dcc1b50. Read the comment docs.

Copy link

codecov bot commented Jul 9, 2024

Bundle Report

Changes will increase total bundle size by 831 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 6.08MB 831 bytes ⬆️

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 831 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.08MB 831 bytes ⬆️

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
dcc1b50 Tue, 09 Jul 2024 23:00:31 GMT Cloud Enterprise

@ajay-sentry ajay-sentry added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit 2b00a92 Jul 10, 2024
61 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/1973-tax-id-plan-page branch July 10, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gazebo] Add Tax Info to Plan Page
3 participants