[feat] Add repo level exceeded GH rate limit banner #2999
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2999 +/- ##
=======================================
Coverage 98.35% 98.36%
=======================================
Files 910 912 +2
Lines 13534 13563 +29
Branches 3659 3595 -64
=======================================
+ Hits 13312 13341 +29
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2999 +/- ##
=======================================
Coverage 98.35% 98.36%
=======================================
Files 910 912 +2
Lines 13534 13563 +29
Branches 3664 3666 +2
=======================================
+ Hits 13312 13341 +29
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #2999 +/- ##
=======================================
Coverage 98.35% 98.36%
=======================================
Files 910 912 +2
Lines 13534 13563 +29
Branches 3659 3666 +7
=======================================
+ Hits 13312 13341 +29
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 7.61kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 7.61kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2999 +/- ##
================================================
+ Coverage 98.35000 98.36000 +0.01000
================================================
Files 910 912 +2
Lines 13534 13563 +29
Branches 3638 3595 -43
================================================
+ Hits 13312 13341 +29
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
rohitvinnakota-codecov
changed the title
rohitvinnakota-codecov
changed the title
| }) | ||
| } | ||
|
|
||
| if (data?.owner?.repository?.__typename === 'OwnerNotActivatedError') { |
There was a problem hiding this comment.
Just want to confirm we don't want to return a Promise.reject() for these two cases
There was a problem hiding this comment.
Yeah, avoiding any page level errors as this does not block critical functionality.
There was a problem hiding this comment.
got it, thanks for confirming
| </Alert.Title> | ||
| <Alert.Description> | ||
| <p className="flex items-center gap-2"> | ||
| Unable to calculate coverage due to GitHub rate limit exceeded. |
There was a problem hiding this comment.
Keeping consistency with what I see on google lol
Description
This banner will show up on the Commit detail and PR detail page if there is a GH rate limit error. This info will be surfaced via a resolver from the API(which queries a redis cache under the hood).
Related API changes: codecov/codecov-api@56269e3
We make a call to Github when the files changed tab is expanded, or a file is viewed.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.