Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New header polish #3017

Merged
merged 9 commits into from
Jul 17, 2024
Merged

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Jul 15, 2024

This PR adds the final polish on the new header.

  • Adjust styles to fix some weirdness that was happening.
  • Add guest header to new header
  • Code cleanup
  • Fix pull and commit details breadcrumb

@codecov-staging
Copy link

codecov-staging bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3017   +/-   ##
=======================================
  Coverage   98.35%   98.36%           
=======================================
  Files         910      911    +1     
  Lines       13534    13556   +22     
  Branches     3664     3597   -67     
=======================================
+ Hits        13312    13334   +22     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx 96.42% <ø> (ø)
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <100.00%> (ø)
.../layouts/Header/components/Navigator/Navigator.tsx 100.00% <100.00%> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <ø> (ø)
src/pages/AccountSettings/AccountSettings.jsx 100.00% <ø> (ø)
src/pages/AccountSettings/shared/Header/Header.jsx 100.00% <ø> (ø)
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <100.00%> (ø)
src/pages/CommitDetailPage/CommitDetailPage.tsx 100.00% <100.00%> (ø)
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <100.00%> (ø)
... and 10 more
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <100.00%> (+0.04%) ⬆️
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (ø)
UI 94.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0756143...3075088. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (0756143) to head (3075088).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3017   +/-   ##
=======================================
  Coverage   98.35%   98.36%           
=======================================
  Files         910      911    +1     
  Lines       13534    13556   +22     
  Branches     3659     3597   -62     
=======================================
+ Hits        13312    13334   +22     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx 96.42% <ø> (ø)
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <100.00%> (ø)
.../layouts/Header/components/Navigator/Navigator.tsx 100.00% <100.00%> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <ø> (ø)
src/pages/AccountSettings/AccountSettings.jsx 100.00% <ø> (ø)
src/pages/AccountSettings/shared/Header/Header.jsx 100.00% <ø> (ø)
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <100.00%> (ø)
src/pages/CommitDetailPage/CommitDetailPage.tsx 100.00% <100.00%> (ø)
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <100.00%> (ø)
... and 10 more
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <100.00%> (+0.04%) ⬆️
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (ø)
UI 94.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0756143...3075088. Read the comment docs.

Copy link

codecov-public-qa bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (0756143) to head (3075088).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3017   +/-   ##
=======================================
  Coverage   98.35%   98.36%           
=======================================
  Files         910      911    +1     
  Lines       13534    13556   +22     
  Branches     3659     3647   -12     
=======================================
+ Hits        13312    13334   +22     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx 96.42% <ø> (ø)
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <100.00%> (ø)
.../layouts/Header/components/Navigator/Navigator.tsx 100.00% <100.00%> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <ø> (ø)
src/pages/AccountSettings/AccountSettings.jsx 100.00% <ø> (ø)
src/pages/AccountSettings/shared/Header/Header.jsx 100.00% <ø> (ø)
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <100.00%> (ø)
src/pages/CommitDetailPage/CommitDetailPage.tsx 100.00% <100.00%> (ø)
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <100.00%> (ø)
... and 10 more
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <100.00%> (+0.04%) ⬆️
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (ø)
UI 94.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0756143...3075088. Read the comment docs.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (0756143) to head (3075088).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3017        +/-   ##
================================================
+ Coverage   98.35000   98.36000   +0.01000     
================================================
  Files           910        911         +1     
  Lines         13534      13556        +22     
  Branches       3638       3597        -41     
================================================
+ Hits          13312      13334        +22     
  Misses          218        218                
  Partials          4          4                
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx 96.42% <ø> (ø)
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <100.00%> (ø)
.../layouts/Header/components/Navigator/Navigator.tsx 100.00% <100.00%> (ø)
src/layouts/LoginLayout/LoginLayout.tsx 100.00% <ø> (ø)
src/pages/AccountSettings/AccountSettings.jsx 100.00% <ø> (ø)
src/pages/AccountSettings/shared/Header/Header.jsx 100.00% <ø> (ø)
src/pages/AnalyticsPage/AnalyticsPage.jsx 100.00% <100.00%> (ø)
src/pages/CommitDetailPage/CommitDetailPage.tsx 100.00% <100.00%> (ø)
...pages/CommitDetailPage/hooks/useCommitPageData.tsx 100.00% <100.00%> (ø)
... and 10 more
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <100.00%> (+0.04%) ⬆️
Pages 99.16% <100.00%> (+<0.01%) ⬆️
Services 99.47% <100.00%> (+<0.01%) ⬆️
Shared 99.69% <ø> (ø)
UI 94.28% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0756143...3075088. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jul 15, 2024

Bundle Report

Changes will increase total bundle size by 1.16kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 6.08MB 1.16kB ⬆️

Copy link

codecov bot commented Jul 15, 2024

Bundle Report

Changes will increase total bundle size by 1.16kB ⬆️

Bundle name Size Change
gazebo-production-array-push 6.08MB 1.16kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 15, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
09659e5 Mon, 15 Jul 2024 17:07:14 GMT Expired Expired
9f671f1 Mon, 15 Jul 2024 18:44:06 GMT Expired Expired
9f671f1 Mon, 15 Jul 2024 18:51:21 GMT Expired Expired
65b95d5 Mon, 15 Jul 2024 19:20:52 GMT Expired Expired
358d3f6 Tue, 16 Jul 2024 14:02:37 GMT Expired Expired
9d17efa Tue, 16 Jul 2024 15:28:14 GMT Expired Expired
9717451 Tue, 16 Jul 2024 17:24:22 GMT Expired Expired
b8c03ff Tue, 16 Jul 2024 19:49:10 GMT Expired Expired
dd90240 Wed, 17 Jul 2024 14:10:00 GMT Expired Expired
3075088 Wed, 17 Jul 2024 18:26:23 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/new-header-styling branch 4 times, most recently from 358d3f6 to 9d17efa Compare July 16, 2024 15:17
@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 16, 2024 17:24
@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/new-header-styling branch from b8c03ff to dd90240 Compare July 17, 2024 13:59
@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/new-header-styling branch from dd90240 to 3075088 Compare July 17, 2024 18:16
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 2f737fb Jul 17, 2024
61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/new-header-styling branch July 17, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants