Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add impersonation banner to new header #3036

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Jul 18, 2024

Adds a pink banner that will show when the user is impersonating another user. Also slightly adjusts the layout of the guest header to match what it was before.

Screenshot 2024-07-18 at 15 32 56

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 18, 2024 19:32
@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 236 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.86MB 236 bytes ⬆️

Copy link

codecov bot commented Jul 18, 2024

Bundle Report

Changes will increase total bundle size by 236 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 5.86MB 236 bytes ⬆️

Copy link

codecov-public-qa bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (2c9953c) to head (d020c31).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3036   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         914      914           
  Lines       13604    13608    +4     
  Branches     3679     3687    +8     
=======================================
+ Hits        13382    13386    +4     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.73% <100.00%> (+0.02%) ⬆️
Pages 99.16% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9953c...d020c31. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (2c9953c) to head (d020c31).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3036   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         914      914           
  Lines       13604    13608    +4     
  Branches     3679     3610   -69     
=======================================
+ Hits        13382    13386    +4     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.73% <100.00%> (+0.02%) ⬆️
Pages 99.16% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9953c...d020c31. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3036   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files         914      914           
  Lines       13604    13608    +4     
  Branches     3684     3687    +3     
=======================================
+ Hits        13382    13386    +4     
  Misses        218      218           
  Partials        4        4           
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.73% <100.00%> (+0.02%) ⬆️
Pages 99.16% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9953c...d020c31. Read the comment docs.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (2c9953c) to head (d020c31).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3036   +/-   ##
===========================================
  Coverage   98.36000   98.36000           
===========================================
  Files           914        914           
  Lines         13604      13608    +4     
  Branches       3679       3660   -19     
===========================================
+ Hits          13382      13386    +4     
  Misses          218        218           
  Partials          4          4           
Files Coverage Δ
src/layouts/Header/Header.tsx 100.00% <100.00%> (ø)
...outs/Header/components/GuestHeader/GuestHeader.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.73% <100.00%> (+0.02%) ⬆️
Pages 99.16% <ø> (ø)
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 94.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c9953c...d020c31. Read the comment docs.

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/new-header-tweaks branch from 8607f43 to d020c31 Compare July 19, 2024 13:24
@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
d020c31 Fri, 19 Jul 2024 13:31:36 GMT Cloud Enterprise

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 14ca658 Jul 19, 2024
61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/new-header-tweaks branch July 19, 2024 13:58
Copy link

sentry-io bot commented Jul 24, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SyntaxError: Unexpected token '<', "<!doctype "... is not valid JSON /:provider/:owner/:repo/pull/:pullId View Issue
  • ‼️ SyntaxError: Unexpected token '<', "<!doctype "... is not valid JSON /:provider/:owner/:repo/tree/:branch/:path+ View Issue
  • ‼️ SyntaxError: Unexpected token '<', "<!doctype "... is not valid JSON /:provider/:owner/:repo/new View Issue
  • ‼️ SyntaxError: Unexpected token '<', "<!doctype "... is not valid JSON /:provider/:owner View Issue
  • ‼️ SyntaxError: Unexpected token '<', "<!doctype "... is not valid JSON /:provider/:owner/:repo/commit/:commit/blob/:path+ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants