-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add impersonation banner to new header #3036
Conversation
Bundle ReportChanges will increase total bundle size by 236 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 236 bytes ⬆️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3036 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 914 914
Lines 13604 13608 +4
Branches 3679 3687 +8
=======================================
+ Hits 13382 13386 +4
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3036 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 914 914
Lines 13604 13608 +4
Branches 3679 3610 -69
=======================================
+ Hits 13382 13386 +4
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3036 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 914 914
Lines 13604 13608 +4
Branches 3684 3687 +3
=======================================
+ Hits 13382 13386 +4
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3036 +/- ##
===========================================
Coverage 98.36000 98.36000
===========================================
Files 914 914
Lines 13604 13608 +4
Branches 3679 3660 -19
===========================================
+ Hits 13382 13386 +4
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
8607f43
to
d020c31
Compare
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Adds a pink banner that will show when the user is impersonating another user. Also slightly adjusts the layout of the guest header to match what it was before.