feat: Create logic for OKTA banners #3043
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3043 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 914 915 +1
Lines 13604 13615 +11
Branches 3657 3687 +30
=======================================
+ Hits 13382 13393 +11
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3043 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 914 915 +1
Lines 13604 13615 +11
Branches 3679 3610 -69
=======================================
+ Hits 13382 13393 +11
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3043 +/- ##
===========================================
Coverage 98.36000 98.36000
===========================================
Files 914 915 +1
Lines 13604 13615 +11
Branches 3657 3687 +30
===========================================
+ Hits 13382 13393 +11
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3043 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 914 915 +1
Lines 13604 13615 +11
Branches 3679 3682 +3
=======================================
+ Hits 13382 13393 +11
Misses 218 218
Partials 4 4
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 5.77kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 5.77kB ⬆️
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
|
|
||
| const oktaConfig = data?.owner?.account?.oktaConfig | ||
|
|
||
| if (!owner || !oktaConfig?.enabled || !data?.owner?.isUserOktaAuthenticated) |
There was a problem hiding this comment.
nit: can potentially move the !owner call to before the hook if we want to avoid calling the hook
Its a slight perf upgrade, not sure how much its worth in practice
There was a problem hiding this comment.
Can't unconditionally call a hook!
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Description
Conditionally render OKTA banners according to enabled/enforced settings.
NOTE: keeping this as a draft until we have the API work ready
Notable Changes
Screenshots
nothing visual changed.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.