Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create components for use in configuration manager #3056

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Jul 25, 2024

Implements some new components to be used on the new repo configuration manager menu. I initially had a massive PR for all this stuff, but am breaking it down. This is just the components, no invocations of them exist yet though.

Screenshot 2024-07-25 at 11 57 35

Copy link

codecov-public-qa bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (78d982e) to head (d148312).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3056      +/-   ##
==========================================
- Coverage   98.08%   98.04%   -0.04%     
==========================================
  Files         918      924       +6     
  Lines       13722    13762      +40     
  Branches     3723     3734      +11     
==========================================
+ Hits        13459    13493      +34     
- Misses        259      265       +6     
  Partials        4        4              
Files Coverage Δ
...onManager/components/FeatureGroup/FeatureGroup.tsx 100.00% <100.00%> (ø)
...tionManager/components/FeatureItem/FeatureItem.tsx 100.00% <100.00%> (ø)
src/ui/A/A.jsx 100.00% <ø> (ø)
src/ui/Card/Card.tsx 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <ø> (ø)
Pages 98.62% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <100.00%> (-0.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78d982e...d148312. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3056      +/-   ##
==========================================
- Coverage   98.08%   98.04%   -0.04%     
==========================================
  Files         918      924       +6     
  Lines       13722    13762      +40     
  Branches     3723     3734      +11     
==========================================
+ Hits        13459    13493      +34     
- Misses        259      265       +6     
  Partials        4        4              
Files Coverage Δ
...onManager/components/FeatureGroup/FeatureGroup.tsx 100.00% <100.00%> (ø)
...tionManager/components/FeatureItem/FeatureItem.tsx 100.00% <100.00%> (ø)
src/ui/A/A.jsx 100.00% <ø> (ø)
src/ui/Card/Card.tsx 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <ø> (ø)
Pages 98.62% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <100.00%> (-0.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78d982e...d148312. Read the comment docs.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (78d982e) to head (d148312).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3056        +/-   ##
================================================
- Coverage   98.08000   98.04000   -0.04000     
================================================
  Files           918        924         +6     
  Lines         13722      13762        +40     
  Branches       3699       3659        -40     
================================================
+ Hits          13459      13493        +34     
- Misses          259        265         +6     
  Partials          4          4                
Files Coverage Δ
...onManager/components/FeatureGroup/FeatureGroup.tsx 100.00% <100.00%> (ø)
...tionManager/components/FeatureItem/FeatureItem.tsx 100.00% <100.00%> (ø)
src/ui/A/A.jsx 100.00% <ø> (ø)
src/ui/Card/Card.tsx 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <ø> (ø)
Pages 98.62% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <100.00%> (-0.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78d982e...d148312. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.04%. Comparing base (78d982e) to head (d148312).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3056      +/-   ##
==========================================
- Coverage   98.08%   98.04%   -0.04%     
==========================================
  Files         918      924       +6     
  Lines       13722    13762      +40     
  Branches     3728     3710      -18     
==========================================
+ Hits        13459    13493      +34     
- Misses        259      265       +6     
  Partials        4        4              
Files Coverage Δ
...onManager/components/FeatureGroup/FeatureGroup.tsx 100.00% <100.00%> (ø)
...tionManager/components/FeatureItem/FeatureItem.tsx 100.00% <100.00%> (ø)
src/ui/A/A.jsx 100.00% <ø> (ø)
src/ui/Card/Card.tsx 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.71% <ø> (ø)
Pages 98.62% <100.00%> (+<0.01%) ⬆️
Services 99.47% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <100.00%> (-0.38%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78d982e...d148312. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 5.11kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.88MB 5.11kB ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 25, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
1c47cb1 Thu, 25 Jul 2024 16:00:33 GMT Expired Expired
d2c2fcb Thu, 25 Jul 2024 17:15:17 GMT Expired Expired
d148312 Thu, 25 Jul 2024 21:32:33 GMT Cloud Enterprise

Copy link

codecov bot commented Jul 25, 2024

Bundle Report

Changes will increase total bundle size by 5.11kB ⬆️

Bundle name Size Change
gazebo-production-array-push 5.88MB 5.11kB ⬆️

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 25, 2024 17:43
Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two quick comments to peak at

@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/IAM-components branch from d2c2fcb to d148312 Compare July 25, 2024 21:22
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 37c2fd1 Jul 25, 2024
57 of 61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/IAM-components branch July 25, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants