-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create components for use in configuration manager #3056
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3056 +/- ##
==========================================
- Coverage 98.08% 98.04% -0.04%
==========================================
Files 918 924 +6
Lines 13722 13762 +40
Branches 3723 3734 +11
==========================================
+ Hits 13459 13493 +34
- Misses 259 265 +6
Partials 4 4
... and 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3056 +/- ##
==========================================
- Coverage 98.08% 98.04% -0.04%
==========================================
Files 918 924 +6
Lines 13722 13762 +40
Branches 3723 3734 +11
==========================================
+ Hits 13459 13493 +34
- Misses 259 265 +6
Partials 4 4
... and 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3056 +/- ##
================================================
- Coverage 98.08000 98.04000 -0.04000
================================================
Files 918 924 +6
Lines 13722 13762 +40
Branches 3699 3659 -40
================================================
+ Hits 13459 13493 +34
- Misses 259 265 +6
Partials 4 4
... and 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3056 +/- ##
==========================================
- Coverage 98.08% 98.04% -0.04%
==========================================
Files 918 924 +6
Lines 13722 13762 +40
Branches 3728 3710 -18
==========================================
+ Hits 13459 13493 +34
- Misses 259 265 +6
Partials 4 4
... and 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 5.11kB ⬆️
|
Bundle ReportChanges will increase total bundle size by 5.11kB ⬆️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two quick comments to peak at
src/pages/RepoPage/SettingsTab/tabs/ConfigurationManager/components/FeatureItem/FeatureItem.tsx
Outdated
Show resolved
Hide resolved
src/pages/RepoPage/SettingsTab/tabs/ConfigurationManager/components/FeatureItem/FeatureItem.tsx
Outdated
Show resolved
Hide resolved
d2c2fcb
to
d148312
Compare
Implements some new components to be used on the new repo configuration manager menu. I initially had a massive PR for all this stuff, but am breaking it down. This is just the components, no invocations of them exist yet though.