Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove old header #3076

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Conversation

spalmurray-codecov
Copy link
Contributor

Removes the OldHeader component in Layouts. More clean up to come followed by removing the new header feature flag.

Closes codecov/engineering-team#1959

@codecov-staging
Copy link

codecov-staging bot commented Jul 29, 2024

Bundle Report

Changes will decrease total bundle size by 6.16kB ⬇️

Bundle name Size Change
gazebo-staging-array-push 5.83MB 6.16kB ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (f407689) to head (e151b6a).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3076      +/-   ##
==========================================
- Coverage   98.28%   98.27%   -0.01%     
==========================================
  Files         928      922       -6     
  Lines       13916    13860      -56     
  Branches     3769     3750      -19     
==========================================
- Hits        13677    13621      -56     
  Misses        235      235              
  Partials        4        4              
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx 96.15% <ø> (-0.28%) ⬇️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.38% <ø> (-0.37%) ⬇️
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f407689...e151b6a. Read the comment docs.

Copy link

codecov-public-qa bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (f407689) to head (e151b6a).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3076      +/-   ##
==========================================
- Coverage   98.28%   98.27%   -0.01%     
==========================================
  Files         928      922       -6     
  Lines       13916    13860      -56     
  Branches     3769     3750      -19     
==========================================
- Hits        13677    13621      -56     
  Misses        235      235              
  Partials        4        4              
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx 96.15% <ø> (-0.28%) ⬇️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.38% <ø> (-0.37%) ⬇️
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f407689...e151b6a. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3076      +/-   ##
==========================================
- Coverage   98.28%   98.27%   -0.01%     
==========================================
  Files         928      922       -6     
  Lines       13916    13860      -56     
  Branches     3769     3774       +5     
==========================================
- Hits        13677    13621      -56     
  Misses        235      235              
  Partials        4        4              
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx 96.15% <ø> (-0.28%) ⬇️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.38% <ø> (-0.37%) ⬇️
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f407689...e151b6a. Read the comment docs.

Copy link

codecov bot commented Jul 29, 2024

Bundle Report

Changes will decrease total bundle size by 6.16kB ⬇️

Bundle name Size Change
gazebo-production-array-push 5.83MB 6.16kB ⬇️

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.27%. Comparing base (f407689) to head (e151b6a).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main      #3076        +/-   ##
================================================
- Coverage   98.28000   98.27000   -0.01000     
================================================
  Files           928        922         -6     
  Lines         13916      13860        -56     
  Branches       3716       3774        +58     
================================================
- Hits          13677      13621        -56     
  Misses          235        235                
  Partials          4          4                
Files Coverage Δ
src/layouts/BaseLayout/BaseLayout.jsx 96.15% <ø> (-0.28%) ⬇️
Components Coverage Δ
Assets 53.84% <ø> (ø)
Layouts 97.38% <ø> (-0.37%) ⬇️
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.69% <ø> (ø)
UI 93.99% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f407689...e151b6a. Read the comment docs.

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review July 29, 2024 18:22
@spalmurray-codecov spalmurray-codecov force-pushed the spalmurray/remove-old-header branch from a878fdc to e151b6a Compare July 29, 2024 18:25
@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jul 29, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
e151b6a Mon, 29 Jul 2024 18:35:17 GMT Expired Expired
e151b6a Mon, 29 Jul 2024 18:43:10 GMT Cloud Enterprise

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

send it!

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Jul 30, 2024
Merged via the queue into main with commit 856f27c Jul 30, 2024
60 of 61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/remove-old-header branch July 30, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove old header and its feature flagging
3 participants