Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make uploads on commit sticky #3125

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Conversation

spalmurray-codecov
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov commented Aug 14, 2024

Makes the uploads card stick properly when scrolling on the commit detail page.

Closes codecov/engineering-team#1534

Screenshot 2024-08-14 at 12 55 41

@spalmurray-codecov spalmurray-codecov marked this pull request as ready for review August 14, 2024 17:03
@codecov-staging
Copy link

codecov-staging bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3125   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         917      917           
  Lines       14143    14143           
  Branches     3833     3913   +80     
=======================================
  Hits        13902    13902           
  Misses        236      236           
  Partials        5        5           
Files Coverage Δ
...CommitDetailPage/CommitCoverage/CommitCoverage.jsx 100.00% <ø> (ø)
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.78% <ø> (ø)
Pages 99.01% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.48% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a5a630...b6ad38a. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (4a5a630) to head (b6ad38a).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3125   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         917      917           
  Lines       14143    14143           
  Branches     3833     3833           
=======================================
  Hits        13902    13902           
  Misses        236      236           
  Partials        5        5           
Files Coverage Δ
...CommitDetailPage/CommitCoverage/CommitCoverage.jsx 100.00% <ø> (ø)
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.78% <ø> (ø)
Pages 99.01% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.48% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a5a630...b6ad38a. Read the comment docs.

Copy link

codecov-public-qa bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (4a5a630) to head (b6ad38a).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3125   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files         917      917           
  Lines       14143    14143           
  Branches     3833     3913   +80     
=======================================
  Hits        13902    13902           
  Misses        236      236           
  Partials        5        5           
Files Coverage Δ
...CommitDetailPage/CommitCoverage/CommitCoverage.jsx 100.00% <ø> (ø)
src/ui/SummaryDropdown/SummaryDropdown.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.78% <ø> (ø)
Pages 99.01% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.48% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a5a630...b6ad38a. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Copy link

codecov bot commented Aug 14, 2024

Bundle Report

Changes will increase total bundle size by 200 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 5.85MB 200 bytes ⬆️

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Aug 14, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
9d1cf4f Wed, 14 Aug 2024 17:07:42 GMT Expired Expired
b6ad38a Wed, 14 Aug 2024 17:28:11 GMT Cloud Enterprise

Copy link
Contributor

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Aug 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 15, 2024
@spalmurray-codecov spalmurray-codecov added this pull request to the merge queue Aug 15, 2024
Merged via the queue into main with commit 236d39a Aug 15, 2024
61 checks passed
@spalmurray-codecov spalmurray-codecov deleted the spalmurray/sticky-uploads branch August 15, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the position of upload container sticky
3 participants