Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Sentry Profiler and profiling for code renderers #3141

Merged
merged 5 commits into from
Aug 21, 2024
Merged

feat: Add Sentry Profiler and profiling for code renderers #3141

merged 5 commits into from
Aug 21, 2024

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR adds in Sentry's browser profiling integration, as well as HOC profilers for the old and new code renderers. I'll eventually remove the HOC profilers this is to track some data as we transition from the old to new code renderer, whereas the browser profiler integration will continue to hang around. We'll set the profiling collection rate at 10%, which is a percentage of our trace collection rate, so we don't get flooded with profiles, we can always increase this value if we choose to do so.

Notable Changes

  • Add Sentry browser profiling
  • Add HOC profiler to CodeRenderer and VirtualFileRenderer

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 8.22kB ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.78MB 8.22kB ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.30%. Comparing base (eb08cd0) to head (3b6b000).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files Patch % Lines
src/config.js 50.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
- Coverage   98.30%   98.30%   -0.01%     
==========================================
  Files         919      919              
  Lines       14188    14191       +3     
  Branches     3842     3898      +56     
==========================================
+ Hits        13948    13950       +2     
- Misses        235      236       +1     
  Partials        5        5
Files Coverage Δ
src/ui/CodeRenderer/CodeRenderer.tsx 100.00% <ø> (ø)
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.12% <100.00%> (+<0.01%) ⬆️
src/config.js 95.45% <50.00%> (-4.55%) ⬇️
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb08cd0...3b6b000. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.30%. Comparing base (eb08cd0) to head (3b6b000).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
- Coverage   98.30%   98.30%   -0.01%     
==========================================
  Files         919      919              
  Lines       14188    14191       +3     
  Branches     3842     3898      +56     
==========================================
+ Hits        13948    13950       +2     
- Misses        235      236       +1     
  Partials        5        5
Files Coverage Δ
src/ui/CodeRenderer/CodeRenderer.tsx 100.00% <ø> (ø)
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.12% <100.00%> (+<0.01%) ⬆️
src/config.js 95.45% <50.00%> (-4.55%) ⬇️
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb08cd0...3b6b000. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
src/config.js 50.00% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
- Coverage   98.30%   98.30%   -0.01%     
==========================================
  Files         919      919              
  Lines       14188    14191       +3     
  Branches     3923     3898      -25     
==========================================
+ Hits        13948    13950       +2     
- Misses        235      236       +1     
  Partials        5        5
Files Coverage Δ
src/ui/CodeRenderer/CodeRenderer.tsx 100.00% <ø> (ø)
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.12% <100.00%> (+<0.01%) ⬆️
src/config.js 95.45% <50.00%> (-4.55%) ⬇️
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb08cd0...3b6b000. Read the comment docs.

@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024

Bundle Report

Changes will increase total bundle size by 8.22kB ⬆️

Bundle name Size Change
gazebo-production-array-push 5.78MB 8.22kB ⬆️

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
3b6b000 Wed, 21 Aug 2024 15:53:50 GMT Cloud Enterprise

@codecov Codecov
Copy link

codecov bot commented Aug 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.30%. Comparing base (eb08cd0) to head (3b6b000).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files Patch % Lines
src/config.js 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3141   +/-   ##
===========================================
  Coverage   98.30000   98.30000           
===========================================
  Files           919        919           
  Lines         14188      14191    +3     
  Branches       3842       3843    +1     
===========================================
+ Hits          13948      13950    +2     
- Misses          235        236    +1     
  Partials          5          5
Files Coverage Δ
src/ui/CodeRenderer/CodeRenderer.tsx 100.00% <ø> (ø)
src/ui/VirtualFileRenderer/VirtualFileRenderer.tsx 99.12% <100.00%> (+<0.01%) ⬆️
src/config.js 95.45% <50.00%> (-4.55%) ⬇️
Components Coverage Δ
Assets 54.05% <ø> (ø)
Layouts 98.80% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.51% <ø> (ø)
Shared 99.71% <ø> (ø)
UI 94.51% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb08cd0...3b6b000. Read the comment docs.

spalmurray-codecov
spalmurray-codecov approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@spalmurray-codecov spalmurray-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Am pleasantly surprised at how easy this is!

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Aug 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 21, 2024
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Aug 21, 2024
Merged via the queue into main with commit 845a181 Aug 21, 2024
57 of 61 checks passed
@nicholas-codecov nicholas-codecov deleted the add-sentry-profiler-and-profiling branch August 21, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @spalmurray-codecov