Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: z-index issues on pulls and commits #3159

Merged

Conversation

nicholas-codecov
Copy link
Contributor

Description

Some z-index values were off, this is a quick fix to the Select and MultiSelect components.

Closes codecov/engineering-team#2344

Notable Changes

  • Adjust z-index values

Screenshots

Screenshot 2024-09-04 at 12 36 43

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Bundle name Size Change
gazebo-staging-array-push 5.98MB 0 bytes

Copy link

codecov bot commented Sep 4, 2024

Bundle Report

Bundle size has no change ✅

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
698cda3 Wed, 04 Sep 2024 15:49:03 GMT Cloud Enterprise

@codecov-qa
Copy link

codecov-qa bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (337a9c2) to head (698cda3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3159      +/-   ##
==========================================
- Coverage   98.26%   98.26%   -0.01%     
==========================================
  Files         932      932              
  Lines       14448    14448              
  Branches     3907     3939      +32     
==========================================
- Hits        14198    14197       -1     
- Misses        245      246       +1     
  Partials        5        5              
Files with missing lines Coverage Δ
src/ui/MultiSelect/MultiSelect.jsx 100.00% <100.00%> (ø)
src/ui/Select/Select.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.71% <ø> (ø)
UI 94.60% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337a9c2...698cda3. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3159      +/-   ##
==========================================
- Coverage   98.26%   98.26%   -0.01%     
==========================================
  Files         932      932              
  Lines       14448    14448              
  Branches     3939     3852      -87     
==========================================
- Hits        14198    14197       -1     
- Misses        245      246       +1     
  Partials        5        5              
Files Coverage Δ
src/ui/MultiSelect/MultiSelect.jsx 100.00% <100.00%> (ø)
src/ui/Select/Select.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.71% <ø> (ø)
UI 94.60% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337a9c2...698cda3. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (337a9c2) to head (698cda3).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3159      +/-   ##
==========================================
- Coverage   98.26%   98.26%   -0.01%     
==========================================
  Files         932      932              
  Lines       14448    14448              
  Branches     3852     3852              
==========================================
- Hits        14198    14197       -1     
- Misses        245      246       +1     
  Partials        5        5              
Files Coverage Δ
src/ui/MultiSelect/MultiSelect.jsx 100.00% <100.00%> (ø)
src/ui/Select/Select.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.71% <ø> (ø)
UI 94.60% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337a9c2...698cda3. Read the comment docs.

@nicholas-codecov nicholas-codecov added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit 0cae629 Sep 4, 2024
62 of 63 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-eng-2344-fix-z-index-issues-on-pulls-and-commits branch September 4, 2024 15:59
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (337a9c2) to head (698cda3).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##               main      #3159   +/-   ##
===========================================
  Coverage   98.26000   98.26000           
===========================================
  Files           932        932           
  Lines         14448      14448           
  Branches       3934       3939    +5     
===========================================
- Hits          14198      14197    -1     
- Misses          245        246    +1     
  Partials          5          5           
Files with missing lines Coverage Δ
src/ui/MultiSelect/MultiSelect.jsx 100.00% <100.00%> (ø)
src/ui/Select/Select.jsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (ø)
Layouts 98.87% <ø> (ø)
Pages 99.03% <ø> (ø)
Services 99.44% <ø> (-0.04%) ⬇️
Shared 99.71% <ø> (ø)
UI 94.60% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 337a9c2...698cda3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gazebo] "components" selector renders behind "Bundle report" section on PR page
3 participants