-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist Selected Branch Across Tabs/Pages #3181
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3181 +/- ##
==========================================
- Coverage 98.14% 98.13% -0.01%
==========================================
Files 935 935
Lines 14500 14510 +10
Branches 3960 3973 +13
==========================================
+ Hits 14231 14240 +9
- Misses 264 265 +1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3181 +/- ##
==========================================
- Coverage 98.14% 98.13% -0.01%
==========================================
Files 935 935
Lines 14500 14510 +10
Branches 3955 3973 +18
==========================================
+ Hits 14231 14240 +9
- Misses 264 265 +1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3181 +/- ##
==========================================
- Coverage 98.14% 98.13% -0.01%
==========================================
Files 935 935
Lines 14500 14510 +10
Branches 3960 3973 +13
==========================================
+ Hits 14231 14240 +9
- Misses 264 265 +1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3181 +/- ##
================================================
- Coverage 98.14000 98.13000 -0.01000
================================================
Files 935 935
Lines 14500 14510 +10
Branches 3873 3968 +95
================================================
+ Hits 14231 14240 +9
- Misses 264 265 +1
Partials 5 5
... and 1 file with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 887 bytes ⬆️
|
Bundle ReportChanges will increase total bundle size by 887 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Closes codecov/engineering-team#2188
Part 2/2 of https://www.notion.so/sentry/Branch-Selector-Mismatch-Experience-292469a7e517485b80eaf31f3f7d06d8
Code Example
Notable Changes
In order to share the link across page loads, I've tacked on the selected branch to the most of the Repo Page Tabs:
I've excluded Pulls and Configurations as they don't really pertain to having a branch selected. If a user navigates to either of those with a selected branch, it will be wiped away and the user will need to manually switch away from the default branch when they go back to a tab that allows branch selection.
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.