Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add new diff viewer to commit files changed #3356

Merged
merged 5 commits into from
Oct 16, 2024
Merged

chore: Add new diff viewer to commit files changed #3356

merged 5 commits into from
Oct 16, 2024

Conversation

nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Oct 7, 2024 •
edited
Loading

Description

This PR updates the commit detail page files changed commit diff viewer to conditionally use the new virtual diff renderer.

Ticket: codecov/engineering-team#2590

Notable Changes

  • Add nullable to impactedFile in useComparisonForCommitAndParent as it was missing
  • Setup CommitFileDiff to conditionally render old viewer vs new viewer based off of a feature flag
  • Update tests

Screenshots

Screenshot 2024-10-07 at 07 47 24

@codecov-staging
Copy link

codecov-staging bot commented Oct 7, 2024 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 61.97kB (1.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.14MB 61.97kB (1.02%) ⬆️

@codecov Codecov
Copy link

codecov bot commented Oct 7, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 4.95kB (-0.08%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.14MB 4.95kB (-0.08%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (caf3646) to head (ce46fd1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3356   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14233    14244   +11     
  Branches     3927     3926    -1     
=======================================
+ Hits        14117    14128   +11     
  Misses        107      107           
  Partials        9        9
Files with missing lines Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <100.00%> (ø)
...ommitAndParent/useComparisonForCommitAndParent.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf3646...ce46fd1. Read the comment docs.

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (caf3646) to head (ce46fd1).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3356   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14233    14244   +11     
  Branches     3922     3926    +4     
=======================================
+ Hits        14117    14128   +11     
  Misses        107      107           
  Partials        9        9
Files Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <100.00%> (ø)
...ommitAndParent/useComparisonForCommitAndParent.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf3646...ce46fd1. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3356   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14233    14244   +11     
  Branches     3927     3926    -1     
=======================================
+ Hits        14117    14128   +11     
  Misses        107      107           
  Partials        9        9
Files with missing lines Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <100.00%> (ø)
...ommitAndParent/useComparisonForCommitAndParent.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf3646...ce46fd1. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Oct 7, 2024 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
47aa83a Mon, 07 Oct 2024 10:54:32 GMT Expired Expired
041b102 Mon, 07 Oct 2024 16:57:28 GMT Expired Expired
ce46fd1 Wed, 16 Oct 2024 15:57:25 GMT Expired Expired
ce46fd1 Wed, 16 Oct 2024 16:01:03 GMT Cloud Enterprise

@codecov-qa
Copy link

codecov-qa bot commented Oct 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.18%. Comparing base (caf3646) to head (ce46fd1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3356   +/-   ##
=======================================
  Coverage   99.18%   99.18%           
=======================================
  Files         805      805           
  Lines       14233    14244   +11     
  Branches     3922     3931    +9     
=======================================
+ Hits        14117    14128   +11     
  Misses        107      107           
  Partials        9        9
Files with missing lines Coverage Δ
...hangedTab/shared/CommitFileDiff/CommitFileDiff.jsx 100.00% <100.00%> (ø)
...ommitAndParent/useComparisonForCommitAndParent.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.94% <100.00%> (+<0.01%) ⬆️
Services 99.45% <ø> (ø)
Shared 99.80% <ø> (ø)
UI 99.10% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf3646...ce46fd1. Read the comment docs.

ajay-sentry
ajay-sentry approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ✅

@nicholas-codecov nicholas-codecov force-pushed the chore-add-new-diff-viewer-to-commit-files-changed branch from 041b102 to 15e97ec Compare October 16, 2024 15:49
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 978512d Oct 16, 2024
62 checks passed
@nicholas-codecov nicholas-codecov deleted the chore-add-new-diff-viewer-to-commit-files-changed branch October 16, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-sentry ajay-sentry ajay-sentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholas-codecov @codecov-releaser @ajay-sentry