fix: Add script in the index.html if unable to dynamically load asset #3373
Conversation
nicholas-codecov
changed the title
Bundle ReportBundle size has no change ✅ |
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3373 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 802 +3
Lines 14105 14139 +34
Branches 3886 3896 +10
=======================================
+ Hits 13988 14022 +34
Misses 108 108
Partials 9 9 see 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3373 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 802 +3
Lines 14105 14139 +34
Branches 3891 3896 +5
=======================================
+ Hits 13988 14022 +34
Misses 108 108
Partials 9 9 see 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3373 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 802 +3
Lines 14105 14139 +34
Branches 3886 3896 +10
=======================================
+ Hits 13988 14022 +34
Misses 108 108
Partials 9 9 see 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3373 +/- ##
=======================================
Coverage 99.17% 99.17%
=======================================
Files 799 802 +3
Lines 14105 14139 +34
Branches 3891 3896 +5
=======================================
+ Hits 13988 14022 +34
Misses 108 108
Partials 9 9 see 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
nicholas-codecov
deleted the
fix-add-in-reload-script-if-vite-notices-out-of-date-files
branch
Description
Basically we're seeing a lot of failing to load assets in Sentry, this is because of the way our infra is setup, and old versions of the app are not there for the user to request. This is how Vite recommends resolving the issue: load-error-handling.
This PR adds this script into the
index.htmlso it is unaffected by new deployments as the index.html is the file that is consistently served and not cached in the same manner.