feat: Use new chart library for analytics page #3464

nicholas-codecov · 2024-11-05T11:32:22Z

Description

This PR updates the chart being used on the analytics page to use our new chart setup. This PR also includes TS refactors for everything that had to be changed.

Ticket: codecov/engineering-team#2770

Notable Changes

Update analytics page Chart to use new chart library and refactor to TS
Update useCoverage to TS, and reduce the overall amount of things as the new chart library doesn't require as much data as the previous setup
Remove unused prop-type from ChartSelectors (cleaning up the console, and test output)
Update useReposCoverageMeasurements to TS
Create/Update tests

Screenshots

…ests

codecov · 2024-11-05T11:34:43Z

Bundle Report

Changes will decrease total bundle size by 1.1kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-production-system	5.75MB	554 bytes (-0.01%) ⬇️
gazebo-production-system-esm	5.8MB	542 bytes (-0.01%) ⬇️

codecov-staging · 2024-11-05T11:34:46Z

Bundle Report

Changes will decrease total bundle size by 1.1kB (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes

Bundle name	Size	Change
gazebo-staging-system-esm*	5.8MB	542 bytes (-0.01%) ⬇️
gazebo-staging-system	5.75MB	554 bytes (-0.01%) ⬇️

ℹ️ *Bundle size includes cached data from a previous commit

codecov · 2024-11-05T11:35:48Z

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.07%. Comparing base (96f88d8) to head (fea7d53).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/pages/AnalyticsPage/Chart/Chart.tsx	87.50%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
- Coverage   99.09%   99.07%   -0.02%     
==========================================
  Files         804      804              
  Lines       14187    14183       -4     
  Branches     4024     4021       -3     
==========================================
- Hits        14058    14052       -6     
- Misses        120      122       +2     
  Partials        9        9

Files with missing lines	Coverage Δ
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/Chart/useCoverage.ts	`100.00% <100.00%> (ø)`
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx	`100.00% <ø> (ø)`
...rc/services/charts/useReposCoverageMeasurements.ts	`100.00% <100.00%> (ø)`
src/shared/utils/timeseriesCharts.ts	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/Chart/Chart.tsx	`87.50% <87.50%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.77% <94.44%> (-0.03%)`	⬇️
Services	`99.36% <100.00%> (+<0.01%)`	⬆️
Shared	`99.74% <ø> (ø)`
UI	`99.15% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f88d8...fea7d53. Read the comment docs.

codecov-notifications · 2024-11-05T11:35:51Z

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/pages/AnalyticsPage/Chart/Chart.tsx	87.50%	2 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
- Coverage   99.09%   99.07%   -0.02%     
==========================================
  Files         804      804              
  Lines       14187    14183       -4     
  Branches     4017     4021       +4     
==========================================
- Hits        14058    14052       -6     
- Misses        120      122       +2     
  Partials        9        9

Files with missing lines	Coverage Δ
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/Chart/useCoverage.ts	`100.00% <100.00%> (ø)`
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx	`100.00% <ø> (ø)`
...rc/services/charts/useReposCoverageMeasurements.ts	`100.00% <100.00%> (ø)`
src/shared/utils/timeseriesCharts.ts	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/Chart/Chart.tsx	`87.50% <87.50%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.77% <94.44%> (-0.03%)`	⬇️
Services	`99.36% <100.00%> (+<0.01%)`	⬆️
Shared	`99.74% <ø> (ø)`
UI	`99.15% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f88d8...fea7d53. Read the comment docs.

codecov-public-qa · 2024-11-05T11:35:51Z

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.07%. Comparing base (96f88d8) to head (fea7d53).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
- Coverage   99.09%   99.07%   -0.02%     
==========================================
  Files         804      804              
  Lines       14187    14183       -4     
  Branches     4017     4021       +4     
==========================================
- Hits        14058    14052       -6     
- Misses        120      122       +2     
  Partials        9        9

Files	Coverage Δ
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/Chart/useCoverage.ts	`100.00% <100.00%> (ø)`
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx	`100.00% <ø> (ø)`
...rc/services/charts/useReposCoverageMeasurements.ts	`100.00% <100.00%> (ø)`
src/shared/utils/timeseriesCharts.ts	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/Chart/Chart.tsx	`87.50% <87.50%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.77% <94.44%> (-0.03%)`	⬇️
Services	`99.36% <100.00%> (+<0.01%)`	⬆️
Shared	`99.74% <ø> (ø)`
UI	`99.15% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f88d8...fea7d53. Read the comment docs.

codecov-qa · 2024-11-05T11:38:16Z

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.07%. Comparing base (96f88d8) to head (fea7d53).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/pages/AnalyticsPage/Chart/Chart.tsx	87.50%	2 Missing ⚠️

@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
- Coverage   99.09%   99.07%   -0.02%     
==========================================
  Files         804      804              
  Lines       14187    14183       -4     
  Branches     4024     4014      -10     
==========================================
- Hits        14058    14052       -6     
- Misses        120      122       +2     
  Partials        9        9

Files with missing lines	Coverage Δ
src/pages/AnalyticsPage/AnalyticsPage.jsx	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/Chart/useCoverage.ts	`100.00% <100.00%> (ø)`
...es/AnalyticsPage/ChartSelectors/ChartSelectors.jsx	`100.00% <ø> (ø)`
...rc/services/charts/useReposCoverageMeasurements.ts	`100.00% <100.00%> (ø)`
src/shared/utils/timeseriesCharts.ts	`100.00% <ø> (ø)`
src/pages/AnalyticsPage/Chart/Chart.tsx	`87.50% <87.50%> (ø)`

Components	Coverage Δ
Assets	`100.00% <ø> (ø)`
Layouts	`100.00% <ø> (ø)`
Pages	`98.77% <94.44%> (-0.03%)`	⬇️
Services	`99.36% <100.00%> (+<0.01%)`	⬆️
Shared	`99.74% <ø> (ø)`
UI	`99.15% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f88d8...fea7d53. Read the comment docs.

codecov-releaser · 2024-11-05T11:38:36Z

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit	Created	Cloud	Enterprise
`781de1f`	Tue, 05 Nov 2024 11:38:36 GMT	Expired	Expired
`03f9fbd`	Tue, 05 Nov 2024 12:15:54 GMT	Expired	Expired
`baacb51`	Fri, 08 Nov 2024 16:03:28 GMT	Expired	Expired
`fea7d53`	Fri, 08 Nov 2024 18:21:28 GMT	Cloud	Enterprise

… coverage

src/pages/AnalyticsPage/Chart/Chart.tsx

spalmurray-codecov

lgtm couple questions

spalmurray-codecov · 2024-11-08T15:40:13Z

These charts are so much better 😂

…ics-page

This reverts commit 416c9f5.

nicholas-codecov added 3 commits November 5, 2024 07:17

update chart for the analytics page

c4f6e35

update other things to TS and to support the new chart

139a179

be more specific about not rendering the chart and add in some more t…

781de1f

…ests

rework things for better loading patterns and add more tests for more…

03f9fbd

… coverage

spalmurray-codecov reviewed Nov 8, 2024

View reviewed changes

src/pages/AnalyticsPage/Chart/Chart.tsx Show resolved Hide resolved

spalmurray-codecov reviewed Nov 8, 2024

View reviewed changes

src/pages/AnalyticsPage/Chart/Chart.tsx Outdated Show resolved Hide resolved

spalmurray-codecov reviewed Nov 8, 2024

View reviewed changes

src/pages/AnalyticsPage/Chart/Chart.tsx Show resolved Hide resolved

spalmurray-codecov reviewed Nov 8, 2024

View reviewed changes

src/pages/AnalyticsPage/Chart/Chart.tsx Show resolved Hide resolved

spalmurray-codecov approved these changes Nov 8, 2024

View reviewed changes

nicholas-codecov added 4 commits November 8, 2024 11:49

update useCoverage to take fields instead of params

7216cb9

update Chart to take the correct props directly

5fb1df3

pass the updated props to the chart

baacb51

Merge branch 'main' into feat-gh-eng-2770-create-new-chart-for-analyt…

fea7d53

…ics-page

nicholas-codecov added this pull request to the merge queue Nov 8, 2024

Merged via the queue into main with commit 416c9f5 Nov 8, 2024
50 of 62 checks passed

nicholas-codecov deleted the feat-gh-eng-2770-create-new-chart-for-analytics-page branch November 8, 2024 18:44

nicholas-codecov added a commit that referenced this pull request Nov 8, 2024

Revert "feat: Use new chart library for analytics page (#3464)"

5b11025

This reverts commit 416c9f5.

nicholas-codecov mentioned this pull request Nov 8, 2024

Revert "feat: Use new chart library for analytics page" #3478

Closed

nicholas-codecov restored the feat-gh-eng-2770-create-new-chart-for-analytics-page branch November 8, 2024 18:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Use new chart library for analytics page #3464

feat: Use new chart library for analytics page #3464

nicholas-codecov commented Nov 5, 2024

codecov bot commented Nov 5, 2024 •

edited

Loading

codecov-staging bot commented Nov 5, 2024 •

edited

Loading

codecov bot commented Nov 5, 2024 •

edited

Loading

codecov-notifications bot commented Nov 5, 2024 •

edited

Loading

codecov-public-qa bot commented Nov 5, 2024 •

edited

Loading

codecov-qa bot commented Nov 5, 2024 •

edited

Loading

codecov-releaser commented Nov 5, 2024 •

edited

Loading

spalmurray-codecov left a comment

spalmurray-codecov commented Nov 8, 2024

feat: Use new chart library for analytics page #3464

feat: Use new chart library for analytics page #3464

Conversation

nicholas-codecov commented Nov 5, 2024

Description

Notable Changes

Screenshots

codecov bot commented Nov 5, 2024 • edited Loading

Bundle Report

codecov-staging bot commented Nov 5, 2024 • edited Loading

Bundle Report

codecov bot commented Nov 5, 2024 • edited Loading

Codecov Report

codecov-notifications bot commented Nov 5, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Nov 5, 2024 • edited Loading

Codecov Report

codecov-qa bot commented Nov 5, 2024 • edited Loading

Codecov Report

codecov-releaser commented Nov 5, 2024 • edited Loading

✅ Deploy preview for gazebo ready!

spalmurray-codecov left a comment

Choose a reason for hiding this comment

spalmurray-codecov commented Nov 8, 2024

codecov bot commented Nov 5, 2024 •

edited

Loading

codecov-staging bot commented Nov 5, 2024 •

edited

Loading

codecov bot commented Nov 5, 2024 •

edited

Loading

codecov-notifications bot commented Nov 5, 2024 •

edited

Loading

codecov-public-qa bot commented Nov 5, 2024 •

edited

Loading

codecov-qa bot commented Nov 5, 2024 •

edited

Loading

codecov-releaser commented Nov 5, 2024 •

edited

Loading