feat: Migrate isEnterprisePlan to GQL Field #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 438 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 438 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3576 +/- ##
=======================================
Coverage 98.90% 98.91%
=======================================
Files 806 806
Lines 14485 14478 -7
Branches 4116 4112 -4
=======================================
- Hits 14327 14321 -6
+ Misses 151 150 -1
Partials 7 7
... and 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3576 +/- ##
=======================================
Coverage 98.90% 98.91%
=======================================
Files 806 806
Lines 14485 14478 -7
Branches 4109 4105 -4
=======================================
- Hits 14327 14321 -6
+ Misses 151 150 -1
Partials 7 7
... and 4 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
❌ 2 Tests Failed:
View the top 2 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
|
@codecov-ai-reviewer review |
![codecov-ai[bot]](https://avatars.githubusercontent.com/in/797565?s=60&v=4){kind=small}
src/pages/PlanPage/subRoutes/CurrentOrgPlan/CurrentPlanCard/FreePlanCard/FreePlanCard.jsx
Show resolved
Hide resolved
...s/PlanPage/subRoutes/CurrentOrgPlan/CurrentPlanCard/shared/ActionsBilling/ActionsBilling.jsx
Show resolved
Hide resolved
RulaKhaled
approved these changes
Dec 12, 2024
| @@ -161,6 +161,8 @@ describe('AccountSettings', () => { | |||
| plan: { | |||
| ...mockPlanData, | |||
| value: planValue, | |||
| isEnterprisePlan: | |||
There was a problem hiding this comment.
nit: could just do planValue === Plans.USERS_ENTERPRISEM
rohitvinnakota-codecov
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to remove the isEnterprisePlan helper function in Gazebo in favor of the new GraphQL field for the same.
As part of this PR there are also some changes removing the accountDetails hook has the SOT for retrieving a user's plan in favor of the usePlanData hook, which seems to be the "go-to" pattern for more recently created components anyway.
Outside of that, all the tests that touch plan details had to be updated to include this new field, and in the cases where we deprecated the useAccountDetails hook in favor of usePlanData we also had to add or update the mocks to reflect the differences in the plan mocks as well.
Closes codecov/engineering-team#3061
This PR will probably be the "biggest" of these migration PRs because it's the first one. I don't expect others to be as meaty, though they may have just as many files touched
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.