Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing resources #5

Merged
merged 3 commits into from
May 21, 2020
Merged

Conversation

dhirschfeld
Copy link
Member

@dhirschfeld dhirschfeld commented May 21, 2020

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The requirements/ sections should be defined in the following order: build, host, run; instead saw: host, build, run.

@dhirschfeld
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@dhirschfeld
Copy link
Member Author

The recipe as-is doesn't package the resources folder which includes all the icons.

IIUC the reason is the installer uses poetry and so is a bit broken when using pip. In this PR the resources folder is installed directly into site-packages as that is what the poetry installer does and that expectation is hard-coded in the source.

I don't think that's great so I opened an issue - mingrammer/diagrams#163

As-is though, these modifications are required to have a working diagrams package.

@rluria14 rluria14 merged commit 7ec75b6 into conda-forge:master May 21, 2020
@rluria14
Copy link
Contributor

thanks! @dhirschfeld

@dhirschfeld dhirschfeld deleted the missing-resources branch May 21, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants