Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify condition to ignore non-file URIs in RecentlyEditedTracker #4279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ferenci84
Copy link
Contributor

Enhancement of change in #3930

Issue:
#4124

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 03ead03
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/67b8b3bc7448030008efb850
😎 Deploy Preview https://deploy-preview-4279--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ferenci84 this is on the right track but we do want to support fairly arbitrary schemes like wsl, vscode-remote, etc.

Did you see another unsupported scheme come through the logs?

@ferenci84
Copy link
Contributor Author

@ferenci84 this is on the right track but we do want to support fairly arbitrary schemes like wsl, vscode-remote, etc.

Did you see another unsupported scheme come through the logs?

@RomneyDa What I see is that if you edit anything in the workspace (e.g. clear output, change the git commit message), it triggers this, and it tries to read the "file content" but it's not a file in most cases. I think supporting wsl and vscode-remote is an additional feature, while this PR is just a bugfix.

My recommendation is this: merge this PR (since it's a solution to an bug already present), but keep the PR open, if possible, or open a new issue, for the additional feature to support arbitrary schemes and avoid direct file reading to get the content if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants