fix wrong database container name + code simplification #5175
+11
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
When trying to expose a database, Coolify starts an nginx proxy and pass requests to the database container. The problem is that this container name is based on database type instead of using the real service name. For example if the database is mysql, the proxy will try to pass requests to
mysql-UUID
, no matter what the real container name is.For example if you install Firefly using the provided template, it creates a
mysql
service, so amysql-UUID
container. BUT it is actually using a mariadb docker image. So if you try to expose port in this, case, the proxy will try to pass requests tomariadb-UUID
instead ofmysql-UUID
. The result is that the frontend says exposing port was a success, but in the backround the proxy fails to start and keeps restarting forever.As the docker service used for the database can be named whatever, the proxy should use real name instead of assuming based on DB type.