More modern attach menu #2522
Merged
More modern attach menu #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
approved these changes
Jan 16, 2025
Co-authored-by: bjoern <[email protected]>
|
Thanks, looks good! I spoke to @r10s earlier, we agreed upon merging this PR rather sooner than later as there will be conflicts with #2499 (and it's easier for us to deal with them in #2499 than here). I'll squash this PR (although I strongly dislike squashing :D) but this way we can ship a Testflight sooner :) Again: Thanks for your work! |
|
Yep, thanks @zeitschlag Only reason it wasn't merged yet is I hadn't had time to commit and test the proposed changes. Thank you for doing that. |
r10s
added a commit
that referenced
this pull request
Jan 20, 2025
this PR increases the deployment target to iOS 14, meaning that iOS 13 is no longer supported. the reason is that the "modern" menus are supported since iOS 14 only, and using them has quote some postive effect in UI. in theory one could provide fallbacks, as in #2522 , however, that is comparable much effort as we have to duplicate the logic or add an abstraction layer. that seems not to be worth the effort: i checked some stats, this change will affect 0.16% of users - but most of them should even be able to update their devices (all devices that got iOS 13 also got iOS 15) (so, we could also discontinue supporting iOS 14 at some point, but that has 4x more users, so, let's give them a little more time, until we really have bigger incentive) cmp. #2459
r10s
added a commit
that referenced
this pull request
Jan 20, 2025
this PR increases the deployment target to iOS 14, meaning that iOS 13 is no longer supported. the reason is that the "modern" menus are supported since iOS 14 only, and using them has quote some postive effect in UI. in theory one could provide fallbacks, as in #2522 , however, that is comparable much effort as we have to duplicate the logic or add an abstraction layer. that seems not to be worth the effort: i checked some stats, this change will affect 0.16% of users - but most of them should even be able to update their devices (all devices that got iOS 13 also got iOS 15) (so, we could also discontinue supporting iOS 14 at some point, but that has 4x more users, so, let's give them a little more time, until we really have bigger incentive) cmp. #2459
r10s
added a commit
that referenced
this pull request
Jan 22, 2025
this PR increases the deployment target to iOS 14, meaning that iOS 13 is no longer supported. the reason is that the "modern" menus are supported since iOS 14 only, and using them has quote some postive effect in UI. in theory one could provide fallbacks, as in #2522 , however, that is comparable much effort as we have to duplicate the logic or add an abstraction layer. that seems not to be worth the effort: i checked some stats, this change will affect 0.16% of users - but most of them should even be able to update their devices (all devices that got iOS 13 also got iOS 15) (so, we could also discontinue supporting iOS 14 at some point, but that has 4x more users, so, let's give them a little more time, until we really have bigger incentive) cmp. #2459
r10s
added a commit
that referenced
this pull request
Jan 22, 2025
this PR increases the deployment target to iOS 14, meaning that iOS 13 is no longer supported. the reason is that the "modern" menus are supported since iOS 14 only, and using them has quote some postive effect in UI. in theory one could provide fallbacks, as in #2522 , however, that is comparable much effort as we have to duplicate the logic or add an abstraction layer. that seems not to be worth the effort: i checked some stats, this change will affect 0.16% of users - but most of them should even be able to update their devices (all devices that got iOS 13 also got iOS 15) (so, we could also discontinue supporting iOS 14 at some point, but that has 4x more users, so, let's give them a little more time, until we really have bigger incentive) cmp. #2459
This was referenced Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The screenshot is with all experimental options enabled which general users will not have probably.