BREAKING(cache/unstable): configurable cache ejection of thrown or rejected values, change cache type (#6417) #6419
+129
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6419 +/- ##
=======================================
Coverage 96.03% 96.04%
=======================================
Files 562 562
Lines 42418 42439 +21
Branches 6387 6395 +8
=======================================
+ Hits 40738 40762 +24
+ Misses 1641 1638 -3
Partials 39 39 ☔ View full report in Codecov by Sentry. |
lionel-rowe
force-pushed
the
memoize-cache-errors
branch
from
89fc5d2 to
761ddb3
Compare
kt3k
changed the title
|
I'll keep this PR open for a while to see if there are more feedbacks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6417.
I don't love how verbose this makes passing an
LruCacheinstance as amemoizeoption. Ideally it'd be possible to just pass it as a literal{ cache: new LruCache(100) }with the type params being inferred as what they're supposed to be, but I don't think it's possible to do that in TypeScript (???). Passing{ cache: new Map() }works, but only becausenew Map()isMap<any, any>, whereasnew LruCache(n)isLruCache<unknown, unknown>.