Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate from TSLint to ESLint #204

Merged
merged 5 commits into from
Mar 27, 2022
Merged

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented Mar 27, 2022

No description provided.

@jonaskello
Copy link
Member

@F3n67u Thank you for starting this, I have been thinking to get around to it :-)

I changed the package.json script to run eslint instead of tslint. You can try it with yarn lint. It gives some additional warnings, I think it is because the tests were not included. Would you mind fixing those too?

@F3n67u
Copy link
Contributor Author

F3n67u commented Mar 27, 2022

@F3n67u Thank you for starting this, I have been thinking to get around to it :-)

I changed the package.json script to run eslint instead of tslint. You can try it with yarn lint. It gives some additional warnings, I think it is because the tests were not included. Would you mind fixing those too?

thanks for review. all warning is cleared.

@jonaskello jonaskello merged commit e6bc77f into dividab:master Mar 27, 2022
@F3n67u F3n67u deleted the eslint branch March 28, 2022 02:09
@F3n67u
Copy link
Contributor Author

F3n67u commented Mar 28, 2022

@jonaskello could you help review other pr I filed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants