Fix tests and lint #211
Fix tests and lint #211
Conversation
| expect(successResult.resultType).toBe("success"); | ||
| expect(successResult.absoluteBaseUrl).toBe(join("/baz", "src")); | ||
| }); | ||
|
|
||
| it("should show an error message when baseUrl is missing", () => { | ||
| it("should tolerate a missing baseUrl", () => { |
There was a problem hiding this comment.
I believe this test was broken by #208.
| tsConfigPath: "/baz/tsconfig.json", | ||
| baseUrl: "/baz", | ||
| paths: {}, | ||
| }), | ||
| }); | ||
|
|
||
| const successResult = result as ConfigLoaderSuccessResult; | ||
| assert.equal(successResult.absoluteBaseUrl, "/baz"); | ||
| expect(successResult.absoluteBaseUrl).toEqual("/baz"); |
There was a problem hiding this comment.
This was the failing test from #174.
| expect(result).toEqual([ | ||
| { | ||
| pattern: "longest/pre/fix/*", | ||
| paths: [join("/absolute", "base", "url", "foo2", "bar")], | ||
| }, | ||
| { | ||
| pattern: "pre/fix/*", | ||
| paths: [join("/absolute", "base", "url", "foo3")], | ||
| paths: [join("/foo3")], |
There was a problem hiding this comment.
I believe these test cases were broken by #184. I updated them to have a sampling of both relative and absolute paths.
|
@nwalters512 I was trying to get the tests running in CI for the PR. Could you try to merge master into this and push again? |
|
@jonaskello I believe you're missing configuration from |
|
@nwalters512 Ah, thanks, that may be it! It was running for the PR where I changed the workflow but I guess counts as just push. I updated master according to your example, could you try to merge it into this PR again? |
|
@jonaskello looks like we're good now! |
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
- Coverage 70.26% 67.76% -2.50%
==========================================
Files 10 9 -1
Lines 306 304 -2
Branches 92 93 +1
==========================================
- Hits 215 206 -9
- Misses 85 92 +7
Partials 6 6
Continue to review full report at Codecov.
|
|
@nwalters512 Perfect, thanks for the hint :-) |
This fixes the failing test called out in #174 (comment). It also fixes a few more failing tests. The entire test suite now passes!
I also took the opportunity to remove some commented-out assertions and remove a few unnecessary bits that had
// eslint-disable...comments.I would strongly encourage the maintainers to set up CI to run on pull requests, not just on master, so that errors can be caught quickly and resolved before changes are merged!