-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for nested main field selectors #218
Conversation
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 67.97% 68.28% +0.31%
==========================================
Files 9 9
Lines 306 309 +3
Branches 93 95 +2
==========================================
+ Hits 208 211 +3
Misses 92 92
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Altough I would prefer to keep webpack specific stuff in the webpack plugin, resolving nested mainfields in package.json cannot be done in the plugin so I guess we need to add this. |
The jsdoc currently says this about the mainFields param:
@aaronadamsCA Could you update that comment to reflect the new function? Also the same comment is in the readme. |
If you prefer, I can update the downstream PR instead to just throw an error if the script reaches an array. This syntax does not appear to be in wide use anymore; it seems to relate to a proposal that never went anywhere.
Done. |
I think we could have this for completeness so let's merge it and then look into the downstream PR. |
Released in 4.1.0 |
Fixes #217.
There's some slightly repetitive code, I just wasn't sure where a common function should live, so I left the minor copy-paste.