Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace force_text with force_str #546

Merged
merged 5 commits into from
Oct 19, 2020
Merged

Conversation

jrief
Copy link
Collaborator

@jrief jrief commented Oct 15, 2020

This PR replaces the deprecated force_text against force_str.

Since this package dropped support for Python-2 and Django<1.11, there are no compatibility issues.

Copy link
Member

@yakky yakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change this in tests too?

@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #546 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #546   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files          14       14           
  Lines         390      390           
  Branches       41       41           
=======================================
  Hits          260      260           
  Misses        117      117           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0aaa8ee...8a1d05a. Read the comment docs.

@jrief jrief requested a review from yakky October 16, 2020 09:21
@jrief
Copy link
Collaborator Author

jrief commented Oct 16, 2020

@yakky Ups, forgot to change tests as well. Fixed now.

Copy link
Member

@yakky yakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jrief jrief merged commit 7d578cd into master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants