504 copy paste plugins inside ckeditor refer to same instance #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
==========================================
+ Coverage 72.72% 73.22% +0.49%
==========================================
Files 19 19
Lines 825 829 +4
Branches 90 91 +1
==========================================
+ Hits 600 607 +7
+ Misses 200 198 -2
+ Partials 25 24 -1
Continue to review full report at Codecov.
|
|
Looks Good! 👍 |
|
@nichoski do you think, given what we've seen happen here, that a test case could be written for this? |
|
@marksweb yes, it's the least I could do. I just added a test case to this. |
marksweb
approved these changes
Jun 24, 2021
|
This was merged into master, but I don't see it in any of the releases. Is this planned to be added in a new release? Or is it already added and I have issues finding it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing a severe bug caused by pull request 569. In pull request 569, after the referenced plugin is copied successfully, the post_copy method is removing the other child plugins of the plugin we are pasting into, because the other child plugins are not inside the plugins_ziplist provided in the arguments of the post_copy method. This fix is including the existing plugins as well, so they are not touched by the post_copy method.