Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js to version 16 LTS and Gulpfile upgrade as well #593

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

vinitkumar
Copy link
Member

No description provided.

Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an nvmrc file, but other than that is this sorted @vinitkumar ? I can't see the status of checks on my phone for this one 🤔

@vinitkumar vinitkumar changed the title fix: issue with old nodejs package Update Node.js to version 16 LTS and Gul-file upgrade as well Mar 8, 2022
@vinitkumar vinitkumar changed the title Update Node.js to version 16 LTS and Gul-file upgrade as well Update Node.js to version 16 LTS and Gulpfile upgrade as well Mar 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #593 (8cd6c7c) into master (210b05e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #593   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files          19       19           
  Lines         829      829           
  Branches      114      114           
=======================================
  Hits          607      607           
  Misses        198      198           
  Partials       24       24           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210b05e...8cd6c7c. Read the comment docs.

@marksweb marksweb merged commit 0882726 into master Mar 8, 2022
@marksweb marksweb deleted the fix/node-js-upgrade branch March 8, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants