Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove inline editing toggle on touch devices not to clobber view with unused elements #618

Merged
merged 2 commits into from
Jun 19, 2022
Merged

fix: Remove inline editing toggle on touch devices not to clobber view with unused elements #618

merged 2 commits into from
Jun 19, 2022

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Jun 17, 2022

This PR removes the inline editing button on touch devices and in collapsed menus:

  • On touch devices inline editing is deactivated not to interfere with scrolling and other touch interactions with the page. The toggle does not have an effect and can be hidden.
  • Collapsed menus show the right handside toolbar first since it contains major actions (like "Publish"). No need to take away space for the inline editing toggle here.

@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #618 (0ad418e) into master (cc7f1c8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #618   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files          20       20           
  Lines         905      905           
  Branches      128      128           
=======================================
  Hits          678      678           
  Misses        199      199           
  Partials       28       28           
Impacted Files Coverage Δ
djangocms_text_ckeditor/widgets.py 80.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc7f1c8...0ad418e. Read the comment docs.

@fsbraun fsbraun requested a review from marksweb June 17, 2022 11:18
Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a line in the changelog?

@fsbraun
Copy link
Member Author

fsbraun commented Jun 17, 2022

Could you please add a line in the changelog?

Good point. Thanks! 👍

@fsbraun fsbraun merged commit 606fc86 into django-cms:master Jun 19, 2022
@fsbraun fsbraun deleted the fix/inline-editing-toggle branch June 19, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants