Updated ckeditor to v4.21.0 #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sgordeychuk Thanks a lot! We might need to get the latest moono-lisa skin patched to work with dark mode. Can you check locally if the ckeditor skin turns into dark mode if used? The editor is built by running |
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
=======================================
Coverage 76.18% 76.18%
=======================================
Files 20 20
Lines 932 932
Branches 124 124
=======================================
Hits 710 710
Misses 196 196
Partials 26 26 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fsbraun
approved these changes
Apr 18, 2023
|
thanks a lot @fsbraun ! I saw your comment but didn't have a chance to take a look at it, sorry |
netbsd-srcmastr
referenced
this pull request
in NetBSD/pkgsrc
Oct 10, 2023
5.1.4 (2023-10-03) fix: Issue 641 which lead to disappearing content after adding child plugins and cancelling the edit Feature/issue 648 unable to unlink fix: Remove legacy code from Django pre 1.4 fix: test suite for Django 2.2 5.1.3 (2022-06-21) Upgrade Ckeditor to 4.21.0 via `640 https://github.com/django-cms/djangocms-text-ckeditor/pull/640`_ 5.1.2 (2022-12-27) Add suport for django CMS 4.1 Fix 468 via 637: Delay importing models.CMSPlugin in utils to allow adding an HTMLField to a custom user model. 5.1.1 (2022-06-22) Removed inline editing toggle button from touch devices (where it is inactive anyways) and collapsed menus Add workaround for toolbar bug in django CMS < 3.10: Reload page after change in inline editor Fix 578: If parent plugins to not set body css class the default from CKEDITOR_SETTINGS is used 5.1.0 (2022-03-24) Added inline editing fix: Update skin patch to avoid @media query 5.0.1 (2022-03-24) Generated new static bundle. 5.0.0 (2022-03-24) Drop support for Python 3.5 and 3.6 Drop support for django 3.0 Added support for Python 3.9 and 3.10 Added support for django 3.2 Added support for django-cms 3.9 and 3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason of this upgrade was the fix of CVE-2022-24728 ckeditor vulnerability (which worries many people and vulnerability testing tools), but ckeditor builder doesn't allow to just pick version 4.18, so I've upgraded to the latest.
I've tested it in one of ours django cms projects, although I'm not sure how I can share the test results. Please let me know if any additional steps should be taken to test the upgrade.
I've also ran tests using
python setup.py testfor dj32_cms311 and dj41_cms41 envs, the results are: