add support for gw_priority, enable_ipv4 (requires docker v28.0) #12570
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Feb 21, 2025
| @@ -1325,6 +1328,7 @@ func (s *composeService) resolveOrCreateNetwork(ctx context.Context, project *ty | |||
| Attachable: n.Attachable, | |||
| IPAM: ipam, | |||
| EnableIPv6: n.EnableIPv6, | |||
| EnableIPv4: n.EnableIPv4, | |||
There was a problem hiding this comment.
Oh, missed there were more, I should probably mention this one as well; let me see if I can find a PR with a description
There was a problem hiding this comment.
cc @robmry if the description looks good 🙈
This adds support for the GwPriority API field in API v1.48 (docker v28.0). It can be set on both docker container run and docker network connect. This option is used by the Engine to determine which network provides the default gateway for a container. It also adds support for enable_ipv4, which allows enabling (default) or disabling IPv4 address assignment for a network. Co-authored-by: Nicolas De Loof <[email protected]> Signed-off-by: Nicolas De Loof <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
add_gateway_priority
branch
from
3876a65 to
ad1fb0a
Compare
thaJeztah
changed the title
ndeloof
approved these changes
Feb 21, 2025
glours
approved these changes
Feb 21, 2025
robmry
approved these changes
Feb 21, 2025
|
Thanks everyone! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to:
This adds support for the GwPriority API field in API v1.48 (docker v28.0).
It can be set on both docker container run and docker network connect.
This option is used by the Engine to determine which network provides
the default gateway for a container.
It also adds support for enable_ipv4, which allows enabling (default)
or disabling IPv4 address assignment for a network.
What I did
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did