Remove redundant calls to Column::getComment()

doctrine · Feb 24, 2025 · f146c57 · f146c57
1 parent 4d0c016
commit f146c57
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/src/Platforms/AbstractMySQLPlatform.php b/src/Platforms/AbstractMySQLPlatform.php
@@ -329,9 +329,7 @@ public function getAlterTableSQL(TableDiff $diff): array
         $queryParts = [];
 
         foreach ($diff->getAddedColumns() as $column) {
-            $columnProperties = array_merge($column->toArray(), [
-                'comment' => $column->getComment(),
-            ]);
+            $columnProperties = array_merge($column->toArray());
 
             $queryParts[] = 'ADD ' . $this->getColumnDeclarationSQL($columnProperties);
         }
@@ -343,9 +341,7 @@ public function getAlterTableSQL(TableDiff $diff): array
         foreach ($diff->getChangedColumns() as $columnDiff) {
             $newColumn = $columnDiff->getNewColumn();
 
-            $newColumnProperties = array_merge($newColumn->toArray(), [
-                'comment' => $newColumn->getComment(),
-            ]);
+            $newColumnProperties = $newColumn->toArray();
 
             $oldColumn = $columnDiff->getOldColumn();
 

diff --git a/src/Platforms/AbstractPlatform.php b/src/Platforms/AbstractPlatform.php
@@ -2076,7 +2076,6 @@ private function columnToArray(Column $column): array
     {
         return array_merge($column->toArray(), [
             'version' => $column->hasPlatformOption('version') ? $column->getPlatformOption('version') : false,
-            'comment' => $column->getComment(),
         ]);
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -2076,7 +2076,6 @@ private function columnToArray(Column $column): array @@
         {
             return array_merge($column->toArray(), [
                 'version' => $column->hasPlatformOption('version') ? $column->getPlatformOption('version') : false,
-                'comment' => $column->getComment(),
             ]);
         }
@@ Expand Down @@