VideoCommon: move lighting shader logic to callable functions #13347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
custom_shader_overhaul_lighting
branch
from
5d274f2 to
d9b7ca7
Compare
|
@Pokechu22 - at mentioned the others on discord. If you have time, these shader based changes are quite simple. Maybe you could take a look? Blocks another refactor...which blocks a larger feature change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize how difficult #13346 would be to review, so I'm going to split it out in pieces. This will also allow me to catch any fifo errors more easily.
This exposes a function for setting lighting on a channel.