-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Freshness pass and bug fixes: Nullable reference types #43914
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the article to use the language adopted by the C# standards committee to describe the nullable context, and the null state of any variables.
Fixes dotnet#21941: Add description of the default values for arrays of reference types. Fixes dotnet#30348: Edit pass Fixes dotnet#33667: Update the description of the nullable context to match the language used in the C# 8 draft standard Fixes dotnet#36767: Add language on declaring a non-null array of nullable reference types and a nullable array of non-nullable reference types. Also, perform a general edit pass.
ping @adegeo for review |
adegeo
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Few suggestions and approved to let you decide.
BillWagner
commented
Dec 13, 2024
Co-authored-by: Andy (Steve) De George <[email protected]>
BillWagner
commented
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dotnet-csharp/svc
lang-reference/subsvc
okr-freshness
OKR: Freshness of content
okr-quality
Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21941: Add description of the default values for arrays of reference types.
Fixes #30348: Edit pass
Fixes #33667: Update the description of the nullable context to match the language used in the C# 8 draft standard
Fixes #36767: Add language on declaring a non-null array of nullable reference types and a nullable array of non-nullable reference types.
Also, perform a general edit pass.
Internal previews