Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freshness pass and bug fixes: Nullable reference types #43914

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

BillWagner
Copy link
Member

@BillWagner BillWagner commented Dec 9, 2024

Fixes #21941: Add description of the default values for arrays of reference types.
Fixes #30348: Edit pass
Fixes #33667: Update the description of the nullable context to match the language used in the C# 8 draft standard
Fixes #36767: Add language on declaring a non-null array of nullable reference types and a nullable array of non-nullable reference types.

Also, perform a general edit pass.


Internal previews

📄 File 🔗 Preview link
docs/csharp/language-reference/builtin-types/arrays.md Arrays
docs/csharp/language-reference/compiler-options/language.md "Compiler Options - language feature rules"
docs/csharp/language-reference/keywords/where-generic-type-constraint.md where (generic type constraint) (C# Reference)
docs/csharp/language-reference/operators/null-forgiving.md docs/csharp/language-reference/operators/null-forgiving
docs/csharp/nullable-references.md Nullable reference types

Update the article to use the language adopted by the C# standards committee to describe the nullable context, and the null state of any variables.
Fixes dotnet#21941: Add description of the default values for arrays of reference types.
Fixes dotnet#30348: Edit pass
Fixes dotnet#33667:  Update the description of the nullable context to match the language used in the C# 8 draft standard
Fixes dotnet#36767: Add language on declaring a non-null array of nullable reference types and a nullable array of non-nullable reference types.

Also, perform a general edit pass.
@BillWagner BillWagner requested a review from a team as a code owner December 9, 2024 16:23
@dotnetrepoman dotnetrepoman bot added this to the December 2024 milestone Dec 9, 2024
@dotnet-policy-service dotnet-policy-service bot added okr-freshness OKR: Freshness of content okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings. labels Dec 9, 2024
@BillWagner BillWagner requested a review from adegeo December 9, 2024 16:23
@BillWagner
Copy link
Member Author

ping @adegeo for review

Copy link
Contributor

@adegeo adegeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Few suggestions and approved to let you decide.

Co-authored-by: Andy (Steve) De George <[email protected]>
@BillWagner BillWagner enabled auto-merge (squash) December 13, 2024 19:12
@BillWagner BillWagner merged commit 8995edc into dotnet:main Dec 13, 2024
8 checks passed
@BillWagner BillWagner deleted the nullable-freshness branch December 13, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet-csharp/svc lang-reference/subsvc okr-freshness OKR: Freshness of content okr-quality Content-quality KR: Concerns article defects (bugs), freshness, or build warnings.
Projects
None yet
2 participants