-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Collection Rule Trigger Type Console Spew #4883
Fix Collection Rule Trigger Type Console Spew #4883
Conversation
Does this need to be backported? We should also call this out in the release notes. |
I believe so - would that be release 7.1, 7.2, 7.x, and 8.x? I just added the update release notes label. |
8.x will automatically get it from the merge from main; 7.1, 7.2, and 7.x would need it; check if the lack of the |
/backport to release/7.x |
/backport to release/7.2 |
Started backporting to release/7.x: https://github.com/dotnet/dotnet-monitor/actions/runs/5544316821 |
/backport to release/7.1 |
Started backporting to release/7.2: https://github.com/dotnet/dotnet-monitor/actions/runs/5544318809 |
/backport to release/6.x |
Started backporting to release/7.1: https://github.com/dotnet/dotnet-monitor/actions/runs/5544319888 |
Started backporting to release/6.x: https://github.com/dotnet/dotnet-monitor/actions/runs/5544321428 |
Co-authored-by: kkeirstead <[email protected]>
Co-authored-by: kkeirstead <[email protected]>
Co-authored-by: kkeirstead <[email protected]>
Co-authored-by: kkeirstead <[email protected]>
Summary
Currently,
dotnet monitor
emits theCollectionRuleTriggerType
repeatedly in logs:This can lead to huge amounts of console spew as this continues to grow every time the collection rule is triggered. The issue appears to have been tied to
triggerScopeRegistration
failing to be properly disposed in a loop.Release Notes Entry
Prevent overreporting of the collection rule trigger type in console output