Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Collection Rule Trigger Type Console Spew #4883

Merged

Conversation

kkeirstead
Copy link
Member

@kkeirstead kkeirstead commented Jul 12, 2023

Summary

Currently, dotnet monitor emits the CollectionRuleTriggerType repeatedly in logs:

CollectionRuleTriggerTypeDuplication

This can lead to huge amounts of console spew as this continues to grow every time the collection rule is triggered. The issue appears to have been tied to triggerScopeRegistration failing to be properly disposed in a loop.

Release Notes Entry

Prevent overreporting of the collection rule trigger type in console output

@kkeirstead kkeirstead requested a review from a team as a code owner July 12, 2023 19:14
@ghost ghost added the needs-review label Jul 12, 2023
@ghost ghost removed the needs-review label Jul 12, 2023
@jander-msft
Copy link
Member

Does this need to be backported? We should also call this out in the release notes.

@kkeirstead kkeirstead added the update-release-notes Pull requests that should be mentioned in the release notes label Jul 12, 2023
@kkeirstead
Copy link
Member Author

Does this need to be backported? We should also call this out in the release notes.

I believe so - would that be release 7.1, 7.2, 7.x, and 8.x? I just added the update release notes label.

@jander-msft
Copy link
Member

Does this need to be backported? We should also call this out in the release notes.

I believe so - would that be release 7.1, 7.2, 7.x, and 8.x? I just added the update release notes label.

8.x will automatically get it from the merge from main; 7.1, 7.2, and 7.x would need it; check if the lack of the using exists and 6.x and backport it there too if needed

@kkeirstead kkeirstead merged commit 118f72b into dotnet:main Jul 13, 2023
@kkeirstead
Copy link
Member Author

/backport to release/7.x

@kkeirstead
Copy link
Member Author

/backport to release/7.2

@github-actions
Copy link
Contributor

Started backporting to release/7.x: https://github.com/dotnet/dotnet-monitor/actions/runs/5544316821

@kkeirstead
Copy link
Member Author

/backport to release/7.1

@github-actions
Copy link
Contributor

Started backporting to release/7.2: https://github.com/dotnet/dotnet-monitor/actions/runs/5544318809

@kkeirstead
Copy link
Member Author

/backport to release/6.x

@github-actions
Copy link
Contributor

Started backporting to release/7.1: https://github.com/dotnet/dotnet-monitor/actions/runs/5544319888

@github-actions
Copy link
Contributor

Started backporting to release/6.x: https://github.com/dotnet/dotnet-monitor/actions/runs/5544321428

kkeirstead added a commit that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-release-notes Pull requests that should be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants