Return HTTP 400 for disabled features #5527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jander-msft
added
the
update-release-notes
wiktork
reviewed
Oct 11, 2023
src/Microsoft.Diagnostics.Monitoring.WebApi/Controllers/ControllerExtensions.cs
Show resolved
Hide resolved
wiktork
reviewed
Oct 11, 2023
wiktork
previously approved these changes
Oct 12, 2023
wiktork
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Instead of returning HTTP 404 for routes that correspond to disabled feature, return HTTP 400 with a detail message:
curl -k https://localhost:52323/stacks {"status":400,"detail":"The Call Stacks feature is not enabled."}Release Notes Entry
Disabled features with HTTP routes will return HTTP 400