Add semaphore around service scopes dictionary #6570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jander-msft
added
servicing-minor
schmittjoseph
approved these changes
May 2, 2024
|
Let's mention this in the release notes as a bug fix. I'll add the appropriate labels if you can update the |
schmittjoseph
added
the
update-release-notes
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/dotnet-monitor/actions/runs/8927770640 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
_activeEndpointServiceScopesdictionary is largely protected from simultaneous mutation using the_activeEndpointsSemaphoresemaphore. However, there is one place where this lock is not taken which is likely causing the issue reported in #6569. Add the semaphore usage so that the dictionary is fully protected.Release Notes Entry
Fix an issue that could cause monitored processes to fail to resume when in listen mode: #6569