Cleanup Unused Dependencies and Functions in CreateOrderCommandHandler and Test Class #704
+3
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on code cleanup and refactoring to improve maintainability and readability by removing unused parameters and functions in the codebase. The following changes have been made:
Removed Unused Dependencies in CreateOrderCommandHandler:
Deleted the unused private readonly fields:
_identityService (IIdentityService)
_mediator (IMediator)
Updated Test Class NewOrderRequestHandlerTest:
Adjusted the test class to reflect the changes in CreateOrderCommandHandler by removing references or logic that depended on the eliminated dependencies.
Removed Unused Private Function in NewOrderRequestHandlerTest:
Deleted the FakeBuyer private function, which was no longer utilized within the test class.