-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Testing] Enabling more UI Tests by removing platform specific condition - 2 #27500
base: main
Are you sure you want to change the base?
[Testing] Enabling more UI Tests by removing platform specific condition - 2 #27500
Conversation
…agopal/maui into logi-enableuitests7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 13 out of 19 changed files in this pull request and generated no comments.
Files not reviewed (6)
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25371.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue4782.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue3001.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue9580.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue24878.cs: Evaluated as low risk
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue5765.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue9951.cs:20
- Changing the method signature from 'async Task' to 'void' without ensuring that all asynchronous operations are handled correctly could lead to unexpected behavior. Please ensure that 'VerifyScreenshot' does not handle any asynchronous operations internally. If it does, keep the method as 'async Task'.
public void SwitchColorTest()
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue9951.cs
Outdated
Show resolved
Hide resolved
@@ -25,5 +23,4 @@ public void BackgroundFrameResizesFastAndCorrectly() | |||
VerifyScreenshot("BackgroundFrameResizesFastAndCorrectlySizeChanged"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending snapshot on Windows. Available on the latest build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have committed this snapshot in the latest changes, but this method has two snapshots. I will add the first snapshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending on Mac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have committed this snapshot in the latest changes.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue9951.cs
Outdated
Show resolved
Hide resolved
@@ -25,5 +23,4 @@ public void BackgroundFrameResizesFastAndCorrectly() | |||
VerifyScreenshot("BackgroundFrameResizesFastAndCorrectlySizeChanged"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending on Mac.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to update the macOS snapshots.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've changed the logic for taking screenshots on macOS. It has been optimized, now instead of setting the App to full screen and taking the screenshot, we directly get the Window position and size and create a snapshot by cropping the App's content from the screen.
This requires re-committing the updated screenshot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the current Mac snapshots to reflect the latest changes.
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Azure Pipelines successfully started running 3 pipeline(s). |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 2nd group of tests enabled.
Test Cases:
Fixes #22902