[Testing] Enabling more UI Tests by removing platform specific condition - 4 #27561

HarishKumarSF4517 · 2025-02-04T14:10:41Z

Description of Change

The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 4th group of tests enabled.

Test Cases:

CarouselViewUITests.UpdateCurrentItem
Issue10645
Issue10660
Issue17694
Issue20439
Issue20443
Issue20696
Issue20736
Issue20842
Issue20858

Fixes #22902

dotnet-policy-service · 2025-02-04T14:11:11Z

Hey there @HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copilot reviewed 13 out of 19 changed files in this pull request and generated no comments.

Files not reviewed (6)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20858.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20696.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17694.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue10660.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20736.cs: Evaluated as low risk
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue10645.cs: Evaluated as low risk

Comments suppressed due to low confidence (2)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20842.cs:25

The removal of await Task.Delay calls may lead to race conditions in the test. Consider re-adding the delay to ensure the test runs reliably.

App.Tap(scrollDownButton);

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20439.cs:26

Removing the try-finally block might cause issues if the Reset method is necessary for cleaning up after the test. Consider re-adding the try-finally block to ensure proper cleanup.

public void ErrorShouldNotBeThrown()

jsuarezruiz · 2025-02-04T14:53:04Z

/azp run

azure-pipelines · 2025-02-04T14:53:29Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-05T07:05:08Z

/azp run

azure-pipelines · 2025-02-05T07:05:28Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-04T14:52:40Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20443.cs

@@ -1,5 +1,4 @@
-#if ANDROID || IOS
-
+#if TEST_FAILS_ON_CATALYST //DragCoordinates is not working on Catalyst


We can enabled after merge #27339

Hi @jsuarezruiz ,
I have enabled the test for mac and also updated the required snapshot

jsuarezruiz · 2025-02-05T09:52:11Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue17694.cs

@@ -25,5 +24,4 @@ public void Issue17694Test()
 			VerifyScreenshot();


Pending snapshot on macOS.

Updated mac snapshot for Issue17694

jsuarezruiz · 2025-02-05T09:52:35Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue10645.cs

@@ -22,5 +21,4 @@ public void Issue10645Test()
 			VerifyScreenshot();


Pending snapshot on macOS.

Updated mac snapshot for Issue10645

jsuarezruiz · 2025-02-05T09:54:34Z

src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/Issue10645Test.png

Pending on macOS.

jsuarezruiz · 2025-02-05T09:54:50Z

src/Controls/tests/TestCases.iOS.Tests/snapshots/ios/Issue17694Test.png

Pending on macOS.

jsuarezruiz · 2025-02-05T09:55:30Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20443.cs

@@ -1,5 +1,4 @@
-#if ANDROID || IOS
-
+#if TEST_FAILS_ON_CATALYST //DragCoordinates is not working on Catalyst
 using NUnit.Framework;
 using UITest.Appium;
 using UITest.Core;


Pending on Windows.

Updated mac snapshot for Issue20443

Hi @jsuarezruiz ,
Now I have enabled the test for Mac, now you can review it.

jsuarezruiz · 2025-02-07T09:40:58Z

/azp run

azure-pipelines · 2025-02-07T09:41:20Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

We've changed the logic for taking screenshots on macOS. It has been optimized, now instead of setting the App to full screen and taking the screenshot, we directly get the Window position and size and create a snapshot by cropping the App's content from the screen.

This requires re-committing the updated macOS screenshots.

Example:

Issue17694Test

azure-pipelines · 2025-02-09T10:57:50Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-11T07:28:10Z

/azp run

azure-pipelines · 2025-02-11T07:28:31Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-11T12:03:57Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20736.cs

@@ -1,5 +1,4 @@
-#if IOS || WINDOWS
-using NUnit.Framework;
+using NUnit.Framework;


This test is failing on Mac:
Snapshot different than baseline: EditorScrollingWhenEnclosedInBorder.png (0.74% difference)

Could you review it and update the snapshot if necessary?

Hi @jsuarezruiz,
I have reviewed the test and confirmed that the snapshot was necessary. I have also updated the snapshot from the latest build.

The test is failing on Android:

And also keeps failing on macOS, small differences. Could yo review it?

Hi @jsuarezruiz ,
I have made changes in the Test.

jsuarezruiz · 2025-02-12T10:16:01Z

/azp run

azure-pipelines · 2025-02-12T10:16:22Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-12T16:09:10Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue20736.cs

@@ -1,5 +1,4 @@
-#if IOS || WINDOWS
-using NUnit.Framework;
+using NUnit.Framework;


The test is failing on Android:

And also keeps failing on macOS, small differences. Could yo review it?

HarishKumarSF4517 · 2025-02-13T06:44:55Z

Hi @jsuarezruiz ,
I have reviewed the Issue20736 it now working fine in macOS but for Android it fails randomly. I am ensuring now, once after resolve I will notify you

HarishKumarSF4517 · 2025-02-13T08:35:22Z

Hi @jsuarezruiz ,
I have resolved and Updated the changes for Issue20736

jfversluis · 2025-02-16T14:05:44Z

/azp run

azure-pipelines · 2025-02-16T14:06:04Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-18T07:39:00Z

/azp run

azure-pipelines · 2025-02-18T07:39:21Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-19T10:57:38Z

/azp run

azure-pipelines · 2025-02-19T10:58:00Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-21T10:31:46Z

/rebase

jsuarezruiz · 2025-02-21T10:32:42Z

/azp run

azure-pipelines · 2025-02-21T10:33:05Z

Azure Pipelines successfully started running 3 pipeline(s).

Feedback addressed

HarishKumarSF4517 closed this Feb 4, 2025

dotnet-policy-service bot added the community ✨ Community Contribution label Feb 4, 2025

HarishKumarSF4517 reopened this Feb 4, 2025

anandhan-rajagopal added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels Feb 4, 2025

HarishKumarSF4517 marked this pull request as ready for review February 4, 2025 14:20

Copilot bot review requested due to automatic review settings February 4, 2025 14:20

HarishKumarSF4517 requested a review from a team as a code owner February 4, 2025 14:20

HarishKumarSF4517 requested review from StephaneDelcroix and jfversluis February 4, 2025 14:20

Copilot AI reviewed Feb 4, 2025

View reviewed changes

jsuarezruiz requested changes Feb 5, 2025

View reviewed changes

jsuarezruiz requested changes Feb 7, 2025

View reviewed changes

jsuarezruiz requested changes Feb 11, 2025

View reviewed changes

jsuarezruiz previously requested changes Feb 12, 2025

View reviewed changes

HarishKumarSF4517 added 11 commits February 21, 2025 10:32

Enable Migrated Cases in All platforms

ff94661

Updated Issue20842 and UpdateCurrentItem.cs

72fa300

Updated Snapshots

a50574f

Updated Snapshots

23159af

Update EditorScrollingWhenEnclosedInBorder.png

b46f36f

Updated Changes

e4ede4c

Update EditorScrollingWhenEnclosedInBorder.png

17885e7

Update Issue20736.cs

4fba39f

Updated Changes

83cf48e

Updated changes

36e7200

Added Mac Snapshot

8b4e2ef

github-actions bot force-pushed the enable-xamarinuitest-harish30 branch from 3281c24 to 8b4e2ef Compare February 21, 2025 10:32

jfversluis approved these changes Feb 22, 2025

View reviewed changes

jfversluis merged commit 202e523 into dotnet:main Feb 22, 2025
123 checks passed

		@@ -1,5 +1,4 @@
		#if ANDROID \|\| IOS

		#if TEST_FAILS_ON_CATALYST //DragCoordinates is not working on Catalyst

		@@ -25,5 +24,4 @@ public void Issue17694Test()
		VerifyScreenshot();

		@@ -22,5 +21,4 @@ public void Issue10645Test()
		VerifyScreenshot();

[Testing] Enabling more UI Tests by removing platform specific condition - 4 #27561

[Testing] Enabling more UI Tests by removing platform specific condition - 4 #27561

Conversation

HarishKumarSF4517 commented Feb 4, 2025 • edited Loading

Description of Change

Test Cases:

dotnet-policy-service bot commented Feb 4, 2025

Choose a reason for hiding this comment

jsuarezruiz commented Feb 4, 2025

azure-pipelines bot commented Feb 4, 2025

jsuarezruiz commented Feb 5, 2025

azure-pipelines bot commented Feb 5, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsuarezruiz commented Feb 7, 2025 • edited by jfversluis Loading

azure-pipelines bot commented Feb 7, 2025

jsuarezruiz left a comment

Choose a reason for hiding this comment

azure-pipelines bot commented Feb 9, 2025

jsuarezruiz commented Feb 11, 2025

azure-pipelines bot commented Feb 11, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsuarezruiz commented Feb 12, 2025

azure-pipelines bot commented Feb 12, 2025

Choose a reason for hiding this comment

HarishKumarSF4517 commented Feb 13, 2025

HarishKumarSF4517 commented Feb 13, 2025

jfversluis commented Feb 16, 2025

azure-pipelines bot commented Feb 16, 2025

jsuarezruiz commented Feb 18, 2025

azure-pipelines bot commented Feb 18, 2025

jsuarezruiz commented Feb 19, 2025

azure-pipelines bot commented Feb 19, 2025

jsuarezruiz commented Feb 21, 2025

jsuarezruiz commented Feb 21, 2025

azure-pipelines bot commented Feb 21, 2025

HarishKumarSF4517 commented Feb 4, 2025 •

edited

Loading

jsuarezruiz commented Feb 7, 2025 •

edited by jfversluis

Loading