Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Testing] Enabling more UI Tests by removing platform specific condition - 5 #27564

Merged
merged 28 commits into from
Feb 19, 2025
Merged

[Testing] Enabling more UI Tests by removing platform specific condition - 5 #27564

merged 28 commits into from
Feb 19, 2025

Conversation

LogishaSelvarajSF4525
Copy link
Contributor

Description of Change

The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 5th group of tests enabled.

Test Cases:

  • Issue1931
  • Issue23424
  • Issue24670
  • Issue2482
  • Issue25468
  • Issue25473
  • Issue25684
  • Issue26636
  • Issue27542

Fixes #22902

@LogishaSelvarajSF4525 LogishaSelvarajSF4525 added area-testing Unit tests, device tests partner/syncfusion Issues / PR's with Syncfusion collaboration labels Feb 4, 2025
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 4, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz requested changes Feb 5, 2025
View reviewed changes
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue26636.cs
@@ -21,5 +20,4 @@ public void GradientAndShadowShouldWork()
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshot on Windows.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed this snapshot in the latest changes.

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25468.cs Outdated
@@ -21,5 +20,4 @@ public void CollectionViewShouldHaveScrollBar()
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshot on iOS.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz Since the scrollbar in the CollectionView fades out during screenshots on iOS, it's difficult to verify its visibility in UI tests. I will disable this test case for iOS; please share any suggestions you have.

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25684.cs
@@ -20,5 +19,4 @@ public void CustomStyleEditorFromPlatformViewWorks()
VerifyScreenshot();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending snapshot on macOS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed this snapshot in the latest changes.

...ests/TestCases.iOS.Tests/snapshots/ios/VerifyEntryClearButtonVisibilitySetToWhileEditing.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending on macOS.

...trols/tests/TestCases.iOS.Tests/snapshots/ios/VerifyEntryClearButtonVisibilitySetToNever.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending on macOS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz Since the Entry control is not focusing during screenshots on MacCatalyst, the Clear Button is not visible, so I will disable this test case for Mac.

@LogishaSelvarajSF4525 LogishaSelvarajSF4525 marked this pull request as ready for review February 5, 2025 14:10
@LogishaSelvarajSF4525 LogishaSelvarajSF4525 requested a review from a team as a code owner February 5, 2025 14:10
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz requested changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've changed the logic for taking screenshots on macOS. It has been optimized, now instead of setting the App to full screen and taking the screenshot, we directly get the Window position and size and create a snapshot by cropping the App's content from the screen.

This requires re-committing the updated macOS screenshots.

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

StephaneDelcroix
StephaneDelcroix previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@StephaneDelcroix StephaneDelcroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good when green

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Feb 13, 2025 •
edited by jfversluis
Loading

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jfversluis
jfversluis previously approved these changes Feb 14, 2025
View reviewed changes
@jfversluis jfversluis added this to the .NET 9 SR5 milestone Feb 14, 2025
PureWeen
PureWeen previously requested changes Feb 14, 2025
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Verify Entry test needs some work

https://dev.azure.com/xamarin/public/_build/results?buildId=135180&view=ms.vss-test-web.build-test-results-tab&runId=3759783&resultId=100023&paneView=debug

@LogishaSelvarajSF4525
Copy link
Contributor Author

Looks like the Verify Entry test needs some work

https://dev.azure.com/xamarin/public/_build/results?buildId=135180&view=ms.vss-test-web.build-test-results-tab&runId=3759783&resultId=100023&paneView=debug

@PureWeen Restricted the cursor visibility to resolve the flaky outcomes for these test, and committed the changes. please kindly review and share your concerns

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen dismissed their stale review February 18, 2025 16:31

Changes Made

@PureWeen PureWeen merged commit d7147b5 into dotnet:main Feb 19, 2025
123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@PureWeen PureWeen PureWeen left review comments

@mattleibow mattleibow Awaiting requested review from mattleibow mattleibow is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix

Assignees
No one assigned
Labels
area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Milestone
.NET 9 SR5
Development

Successfully merging this pull request may close these issues.

[TEST] Review all (UI) Tests and remove platform-specific runs where possible
6 participants
@LogishaSelvarajSF4525 @jsuarezruiz @mattleibow @StephaneDelcroix @jfversluis @PureWeen