Fix potential ArgumentOutOfRangeException in LeaseBasedQueueBalancer
#9112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a potential for an
ArgumentOutOfRangeExceptionin theLeaseBasedQueueBalancer. This can happen when we remove an element from_myQueueswhile iterating over the results array. When we callRemoveAt(i), we are reducing the size of_myQueues, on subsequent iterations of the for loop,iwill increase, but the length of_myQueueshas decreased. If we reach a point whereiis equal to or greater than the new length of_myQueues, attempting to access_myQueues[i]will throw anArgumentOutOfRangeException. This fix simply loops backwards, this way removing items from_myQueueswill not affect the indices of the remaining elements that are yet to be processed.Microsoft Reviewers: Open in CodeFlow