-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ppc64le] binaryformatter and tensors tests fix #108120
[Ppc64le] binaryformatter and tensors tests fix #108120
Conversation
…l method for ppc64le architecture
Tagging subscribers to this area: @lambdageek, @steveisok |
@akoeplinger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. we will take for consideration in 9 GA
@steveisok can you take a look at the PR failures? |
The builds no longer exist, so I'll have to kick it again. |
…ime.Serialization.Formatters.Tests
Hi @jeffschwMSFT @steveisok @lambdageek @akoeplinger Added changes from PR #108429 which fixes assertion failure which was occurring while running System.Runtime.Serialization.Formatters.Tests tests. This was a very small change in description file. Hence thought to add in this PR instead of opening a new PR against .NET 9 release branch. Can you please merge this PR now? |
Yeah, we'll merge after CI completes. I have no problem with the additional commit as it's ppc specific. |
Thanks @steveisok. |
@alhad-deshpande in the future, once things are approved any additional changes would cause us to go back through the approval process. in this case, it is OK just to have a new code review from @steveisok . |
@jeffschwMSFT |
Fixes #97296. This is a backport PR for release/9.0 branch.
Customer Impact
The IBM team found issues related to float 32 bit load/store operations targeting their ppc64le architecture. This change alters the runtime to generate correct assembler code whenever float32 is used in C# applications.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manual testing
Risk
Low - this change does not target anything we directly ship