[release/9.0] [mini] Don't use Unwind Backtrace on android-amd64 #108294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Match what we do for other android RIDs. The _Unwind_Backtrace support is only used when llvmonly mode is enabled, which is not something that we do for Android, AFAIK
github-actions
bot
requested review from
lambdageek and
steveisok
as code owners
|
Tagging subscribers to this area: @lambdageek, @steveisok |
jeffschwMSFT
approved these changes
Oct 2, 2024
steveisok
approved these changes
Oct 2, 2024
leecow
added
Servicing-approved
This was referenced Oct 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107615 to release/9.0
/cc @lambdageek
Customer Impact
The runtime depends on libunwind on android-x64 but not on any other android platform. This may cause unexpected conflicts on x86-64 android emulators that wouldn't be present on other platforms. The libunwind support is not needed (it is only use for the "llvmonly" AOT mode which isnt' used on Android).
To elaborate: if a user app on Android needs to use libunwind for its own purposes, then there may be build problems (duplicate symbols) that would show up when targeting an x86-64 Android emultator, but not other android architectures.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Manual testing
Risk
Low