[release/9.0-staging] Move ComWrappers AddRef to C/C++ #110815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Xaml invokes AddRef while holding a lock that it *also* holds while a GC is in progress. Managed AddRef had to synchronize with the GC that caused intermittent deadlocks with the other thread holding Xaml's lock. This change reverts the managed AddRef implementation to match .NET Native and CoreCLR. Fixes #110747
Co-authored-by: Aaron Robinson <[email protected]>
…e/InteropServices/ComWrappers.NativeAot.cs
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
AaronRobinsonMSFT
approved these changes
Dec 25, 2024
4 tasks
jeffschwMSFT
added
Servicing-consider
This was referenced Jan 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #110762 to release/9.0-staging
/cc @jkotas
Customer Impact
Intermittent hang, found by Windows Store.
Regression
.NET Native -> .NET 9 regression for UWP/WinUI apps.
Testing
Fix tested on private by Windows Store
Risk
Low. The fix reverts the logic to match .NET Native.
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.