Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-staging] remove extra assert from WinHttp handler #112861

Open
wants to merge 2 commits into
base: release/8.0-staging
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 24, 2025

Backport of #93984 to release/8.0-staging

/cc @ManickaP @wfurt

Customer Impact

  • Customer reported
  • Found internally

Discovered in our CI, the issue is fixed since .NET 9. The problem is that from a certain Windows version, WinHTTP started calling the affected callback sometimes twice (we suspected it came with TLS 1.3). So the change now checks for the second call by checking whether RequestHandle is null or not. Technically the change just swaps assert for if not null.

Note that I tried changes without product code impact without success in #112780.

Regression

  • Yes
  • No

Testing

CI, confirming that WinHttpHandler tests do not crash.

Risk

Low. Firstly, this fix is out in 9.0 and 10.0. Secondly, it's very small change replacing assert with if not null.


Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants