Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arm64: Set zero flag for more comparisons #112863

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

arm64: Set zero flag for more comparisons #112863

wants to merge 1 commit into from
+245 −5

Conversation

jonathandavies-arm
Copy link
Contributor

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Feb 24, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 24, 2025
@jonathandavies-arm
Copy link
Contributor Author

@a74nh @kunalspathak @dotnet/arm64-contrib

This was referenced Feb 24, 2025
Open
Open
Open
Open
jakobbotsch
jakobbotsch reviewed Feb 24, 2025
View reviewed changes
src/coreclr/jit/lower.cpp
if (cmp->OperIs(GT_EQ, GT_NE) && op2->IsIntegralConst(0) && op1->SupportsSettingZeroFlag() &&
BlockRange().TryGetUse(cmp, &use))
if (cmp->OperIs(GT_EQ, GT_NE, GT_GT, GT_GE, GT_LT, GT_LE) && op2->IsIntegralConst(0) &&
op1->SupportsSettingZeroFlag() && BlockRange().TryGetUse(cmp, &use))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SupportsSettingZeroFlag should be renamed to something that indicates the set of flags needed by these comparisons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobbotsch jakobbotsch jakobbotsch left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathandavies-arm @jakobbotsch