Add switch "NotifyUIAProviderTheText" to control screen Reader to announce the content of RichTextBox #12986
+57
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the content of RichTextBox
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12986 +/- ##
===================================================
- Coverage 96.95378% 96.93695% -0.01683%
===================================================
Files 1218 1220 +2
Lines 356671 356867 +196
Branches 5524 5529 +5
===================================================
+ Hits 345806 345936 +130
- Misses 10026 10090 +64
- Partials 839 841 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
ricardobossan
added
the
waiting-review
LeafShi1
force-pushed
the
Issue_12772_Update_RichTextBox_announce_contents
branch
from
ca41d36 to
0902800
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12772
Proposed changes
System.Windows.Forms.RichTextBox.NotifyUIAProviderTheTextto control screen Reader to announce the content of RichTextBoxCustomer Impact
Regression?
Risk
Screenshots
Before
When NVDA get focus, the entire content gets read, not just the currently focused line
After
When the switch is on, Narrator, JAWS and NVDA will read the full contents of the RichTextBox.
When the switch is off, JAWS and NVDA will only read the contents of the currently focused line, while Narrator will not read the contents of the RichTextBox.
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow