Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade #13006

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[main] Update dependencies from dotnet/arcade #13006

wants to merge 2 commits into from
+24 −25

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 22, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: b9a1a4bb-2302-4987-3b3d-08d8b8050dda
  • Build: 20250224.2
  • Date Produced: February 24, 2025 11:10:48 AM UTC
  • Commit: a496a627c10c3c27d9efc83c3c80b3e6a58ccc7b
  • Branch: refs/heads/main
  • Updates to .NET SDKs:
    • Updates sdk.version to 10.0.100-preview.3.25122.1
    • Updates tools.dotnet to 10.0.100-preview.3.25122.1
Microsoft Reviewers: Open in CodeFlow

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
8e2010b 
…220.6

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.25119.2 -> To Version 10.0.0-beta.25120.6
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner February 22, 2025 05:01
dotnet-policy-service[bot]
dotnet-policy-service bot previously approved these changes Feb 22, 2025
View reviewed changes
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go, you big red fire engine!

@LeafShi1
Copy link
Member

LeafShi1 commented Feb 24, 2025 •
edited
Loading

The build failed because the packages Microsoft.DotNet.XUnitExtensions, Version=10.0.0-beta.25120.6 and Microsoft.DotNet.RemoteExecutor, Version=10.0.0-beta.25120.6 are not strongly named signed

CSC : error CS8002: Referenced assembly 'Microsoft.DotNet.XUnitExtensions, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\_work\1\s\src\System.Drawing.Common\tests\System.Drawing.Common.Tests.csproj]
##[error]CSC(0,0): error CS8002: (NETCORE_ENGINEERING_TELEMETRY=Build) Referenced assembly 'Microsoft.DotNet.XUnitExtensions, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.
CSC : error CS8002: Referenced assembly 'Microsoft.DotNet.RemoteExecutor, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\_work\1\s\src\System.Drawing.Common\tests\System.Drawing.Common.Tests.csproj]
##[error]CSC(0,0): error CS8002: (NETCORE_ENGINEERING_TELEMETRY=Build) Referenced assembly 'Microsoft.DotNet.RemoteExecutor, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20250…
ec13512 
…224.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CMake.Sdk , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.25119.2 -> To Version 10.0.0-beta.25124.2
@akoeplinger
Copy link
Member

The strong name issues should be fixed now

@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.05168%. Comparing base (0e15742) to head (ec13512).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##                main      #13006         +/-   ##
===================================================
+ Coverage   76.04779%   76.05168%   +0.00388%     
===================================================
  Files           3269        3269                 
  Lines         643544      643544                 
  Branches       47429       47429                 
===================================================
+ Hits          489401      489426         +25     
+ Misses        150577      150554         -23     
+ Partials        3566        3564          -2
Flag Coverage Δ
Debug 76.05168% <ø> (+0.00388%) ⬆️
integration 18.04035% <ø> (+0.00769%) ⬆️
production 50.03594% <ø> (+0.00976%) ⬆️
test 96.93726% <ø> (-0.00085%) ⬇️
unit 47.49142% <ø> (+0.00768%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnet-policy-service dotnet-policy-service[bot] dotnet-policy-service[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeafShi1 @akoeplinger