client: allow injection of custom kafka clients #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-tincu
force-pushed
the
custom-kafka-clients
branch
from
c4833a8 to
234cca5
Compare
gabriel-tincu
changed the title
|
Related: #735 |
did not realize there was another PR dealing with the same issue. Should i just close this ? Will the other one get merged? |
|
I think this should be kept open, at least until one of them is merged... I think both myself and @dpkp are in favor of allowing injection of custom clients, it was just never pushed across the line. |
dpkp
reviewed
Nov 15, 2020
gabriel-tincu
force-pushed
the
custom-kafka-clients
branch
from
234cca5 to
9e1c9de
Compare
gabriel-tincu
force-pushed
the
custom-kafka-clients
branch
5 times, most recently
from
2d59560 to
274b169
Compare
Provide the consumer, producer and admin client with the option to create the kafka client from a custom callable, thus allowing more flexibility in handling certain low level errors
gabriel-tincu
force-pushed
the
custom-kafka-clients
branch
from
274b169 to
b305761
Compare
|
Did away with the factory function, and opted for the |
|
@dpkp this is ready for another look, whenever you have the time |
|
Looks great -- thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide the consumer, producer and admin client with the option to
create the kafka client from a custom callable, thus allowing more
flexibility in handling certain low level errors
This change is